[Due for payment 2025-07-22] [$250] Expense - "moved this expense to personal space" in per diem expense grays out when offline

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.74-9
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/6414951
Email or phone of affected tester (no customers): jiodnjsoijdoi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has per diem rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two per diem expenses to the workspace chat.
4. Open the expense report.
5. Click More > Delete.
6. Delete the report.
7. Go to self DM.
8. Open the unreported per diem expense.
9. Go offline.

Expected Result:

"moved this expense to your personal space" will not gray out in offline mode.

Actual Result:

"moved this expense to your personal space" grays out in offline mode.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021940923188688861275
• Upwork Job ID: 1940923188688861275
• Last Price Increase: 2025-07-03
• Automatic offers:
• thelullabyy | Contributor | 107919253

Issue Owner

Current Issue Owner: @NicMendonca

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"moved this expense to your personal space" grays out in offline mode.

What is the root cause of that problem?

We added the unreported action in optimistic data, but we forgot to update pendingAction as null in success data then this action is still grayed out after going offline.

App/src/libs/actions/Report.ts

Lines 4874 to 4878 in 9e3b5bd

	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${childReportID}`,
	value: {[unreportedAction.reportActionID]: unreportedAction},
	});

What changes do you think we should make in order to solve the problem?

We should update pendingAction to null in success data and for failure data we can add an error message or remove this action if needed

successData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${childReportID}`,
    value: {[unreportedAction.reportActionID]: {pendingAction: null}},
});

App/src/libs/actions/Report.ts

Lines 4874 to 4878 in 9e3b5bd

	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${childReportID}`,
	value: {[unreportedAction.reportActionID]: unreportedAction},
	});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update deleteAppReport test to verify the pending action of unreported action is updated after the API is success.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021940923188688861275

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@thelullabyy Thanks for the proposal. Your RCA and solution look good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.