[Due for payment 2025-08-05] [$125] Merge accounts - Extra Spacing between the email and domain name in blocked screen

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.74-4

Reproducible in staging?: Yes
Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail: Caught here

Logs: https://stackoverflow.com/c/expensify/questions/4856

Issue reported by: Applause Internal team
Slack conversation (hyperlinked to channel name): N/A

Action Performed:

Preconditions:

• Have private domain account that has SAML enabled
• Have a personal email account (gmail) added to the merge accounts beta

Steps:

1. Login to the personal account that has the merge accounts beta
2. Try to merge the account to a private domain user with SAML enabled
3. A screen indicating that these accounts can't be merged should display

Expected Result:

The spacing in the text explaining that the accounts should not be merged should have regular spacing.

Actual Result:

The email and domain have irregular spacing on the copy.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021940550217662882808
• Upwork Job ID: 1940550217662882808
• Last Price Increase: 2025-07-02
• Automatic offers:
• samranahm | Contributor | 107949373

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra Spacing between the email and domain name in blocked screen

What is the root cause of that problem?

When we submit a form here

App/src/pages/settings/Security/MergeAccounts/AccountDetailsPage.tsx

Lines 153 to 155 in b6a293a

	onSubmit={(values) => {
	requestValidationCodeForAccountMerge(values[INPUT_IDS.PHONE_OR_EMAIL]);
	}}

when we enter an email and add trailing spaces, those spaces are carried over to the error message and the validation screen because we did not trim the values before submitting

What changes do you think we should make in order to solve the problem?

We should use trim() here to make sure we don't have any leading or trailing spaces in login/ email when we submit form

App/src/pages/settings/Security/MergeAccounts/AccountDetailsPage.tsx

Lines 153 to 155 in b6a293a

	onSubmit={(values) => {
	requestValidationCodeForAccountMerge(values[INPUT_IDS.PHONE_OR_EMAIL]);
	}}

onSubmit={(values) => {
    const login = values[INPUT_IDS.PHONE_OR_EMAIL].trim();
    setEmail(login);
    requestValidationCodeForAccountMerge(login);
}}                    

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N//A

What alternative solutions did you explore? (Optional)

we can prevent user to entering space by using .trim onChangeText

here

App/src/pages/settings/Security/MergeAccounts/AccountDetailsPage.tsx

Line 180 in b6a293a

onChangeText={setEmail}

onChangeText={(text) => setEmail(text.trim())}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021940550217662882808

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[sakluger]

Setting the bounty here to $125 since it's a basic styling/alignment issue.

[melvin-bot]

Upwork job price has been updated to $125