Coming from here
Problem
Whenever we open any filter on Search page the Popover gets instantly re-rendered which is bad in general but in more expensive cases causes a significant delay. Most prominent case was UserSelectPopup which on heavy accounts can take up to 0.5s to render itself.
Solution
Recently a new prop was added to PopoverWithMeasuredContent that allows us to cut the unnecessary re-measurements. We should pass shouldSkipRemeasurement={true} prop to PopoverWithMeasuredContent inside src/components/Search/FilterDropdowns/DropdownButton.tsx to avoid extra re-render. This way React uses already memoized children component instead of rendering it from scratch again. Before and after comparison in 🧵
Issue Owner
Current Issue Owner: @isabelastisser
Coming from here
Problem
Whenever we open any filter on Search page the Popover gets instantly re-rendered which is bad in general but in more expensive cases causes a significant delay. Most prominent case was UserSelectPopup which on heavy accounts can take up to 0.5s to render itself.
Solution
Recently a new prop was added to PopoverWithMeasuredContent that allows us to cut the unnecessary re-measurements. We should pass shouldSkipRemeasurement={true} prop to PopoverWithMeasuredContent inside src/components/Search/FilterDropdowns/DropdownButton.tsx to avoid extra re-render. This way React uses already memoized children component instead of rendering it from scratch again. Before and after comparison in 🧵
Issue Owner
Current Issue Owner: @isabelastisser