[Due for payment 2025-08-05] [$250] Share - "Allow Location" modal shows during share workflow & "Import your contacts" reappears briefly after submitting an expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6377157
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 15 iOS 18.5
App Component: Money Requests

Action Performed:

1. Launch ND Hybrid app and sign in with gmail account
2. Clear cache and refresh the app (needed for the "Import your contacts" to appear)
3. Navigate to the device storage, select any receipt and start a sharing flow
4. When in the app, select Submit option
5. Tap "Not now" on the "Import your contacts" modal
6. Select a workspace, tap "Create expense"
7. Tap "Not now" on allow location modal

Expected Result:

User is navigated to the workspace chat, "Import your contacts" modal does not reappear briefly

Actual Result:

"Import your contacts" modal reappears briefly after submitting an expense via Share feature

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021940108026991457008
• Upwork Job ID: 1940108026991457008
• Last Price Increase: 2025-07-08
• Automatic offers:
• nkdengineer | Contributor | 107996159

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Share - "Import your contacts" modal reappears briefly after submitting an expense

What is the root cause of that problem?

• We unmount the <ConfirmModal> immediately when isModalVisible goes false (via return null), which cuts off its exit animation and prevents React Native’s native-modal teardown from running.
• On iOS, <Modal> renders in a separate native window; interrupting its unmount leaves that window alive, so the “closed” modal can reappear during navigation.

App/src/components/ContactPermissionModal/index.native.tsx

Lines 58 to 64 in a8bf844

	if (!isModalVisible) {
	return null;
	}
	return (
	<ConfirmModal
	isVisible={isModalVisible}

What changes do you think we should make in order to solve the problem?

• We should just remove this line because the modal visibility is already being handled using isVisible prop.
  

  App/src/components/ContactPermissionModal/index.native.tsx

  Lines 58 to 60 in a8bf844

  	if (!isModalVisible) {
  	return null;
  	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Result

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Import your contacts" modal reappears briefly after submitting an expense via Share feature

What is the root cause of that problem?

After clicking on the cancel button, we set isModalVisible to false, and this component is unmounted immediately without waiting for the closing animation

App/src/components/ContactPermissionModal/index.native.tsx

Lines 58 to 64 in a8bf844

	if (!isModalVisible) {
	return null;
	}
	return (
	<ConfirmModal
	isVisible={isModalVisible}

When we click on the confirm or cancel button to close the location permission modal, we navigate to the report page without waiting for the modal to close completely, then the Import your contacts modal appears briefly because of the conflict between the close modal animation and navigation transition in IOS.

App/src/pages/Share/SubmitDetailsPage.tsx

Lines 200 to 205 in a8bf844

	onDeny={() => {
	updateLastLocationPermissionPrompt();
	setStartLocationPermissionFlow(false);
	onConfirm(false);
	}}
	/>

What changes do you think we should make in order to solve the problem?

1. We should remove the null return logic here, then the modal can be closed completely.

App/src/components/ContactPermissionModal/index.native.tsx

Lines 58 to 64 in a8bf844

	if (!isModalVisible) {
	return null;
	}
	return (
	<ConfirmModal
	isVisible={isModalVisible}

2. We should use navigateAfterInteraction the same as here to create a transaction and navigate to the report after the modal is closed completely. Apply the same for onGrant. With this change, the original bug was already fixed without point 1 in my proposal. And this change also makes sure this bug will not happen with the share submit expense flow.

onDeny={() => {
    updateLastLocationPermissionPrompt();
    setStartLocationPermissionFlow(false);
    navigateAfterInteraction(() => {
        onConfirm(false);
    });
}}

App/src/pages/Share/SubmitDetailsPage.tsx

Lines 200 to 205 in a8bf844

	onDeny={() => {
	updateLastLocationPermissionPrompt();
	setStartLocationPermissionFlow(false);
	onConfirm(false);
	}}
	/>

Or we can implement a general solution by handling onConfirm/onCancel in onModalHide callback

App/src/components/LocationPermissionModal/index.tsx

Line 133 in a8bf844

onModalHide={() => {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021940108026991457008

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)