[Due for payment 2025-07-15] [$250] Excluded User Still Sees “Your Split” Label in Split Expense UI

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.71-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Go to a group chat with 4 members (e.g., Users A, B, C, D)
2. Have User A create a split expense including all 4 members
3. Then, have User A create another split expense, but this time include only Users A, C, and D, excluding User B
4. Login as User B
5. Observe the expense

Expected Result:

If a user is excluded from a split, the UI should not show “Your split”

Actual Result:

Excluded users see a “Your split” label

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1334.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021938303481336886209
• Upwork Job ID: 1938303481336886209
• Last Price Increase: 2025-06-26

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

Proposal by @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split expense says Your split: $X.XX even though th user is not part of the split:

What is the root cause of that problem?

The shouldShowSplitShare is always true for split bill

App/src/libs/TransactionPreviewUtils.ts

Line 324 in 6b934d1

const shouldShowSplitShare = isBillSplit && !!requestAmount && requestAmount > 0;

And we always fallback the splitShare amount with calculateAmount even though the current user is not a part of the split bill

App/src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx

Lines 146 to 152 in 6b934d1

	const splitShare = useMemo(
	() =>
	shouldShowSplitShare
	? (transaction?.comment?.splits?.find((split) => split.accountID === sessionAccountID)?.amount ??
	calculateAmount(isReportAPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount ?? 0, requestCurrency ?? '', action?.actorAccountID === sessionAccountID))
	: 0,
	[

What changes do you think we should make in order to solve the problem?

We can update shouldShowSplitShare condition to false if the user is not a part of the split bill.

const participantAccountIDs = isMoneyRequestAction(action) && isBillSplit ? (getOriginalMessage(action)?.participantAccountIDs ?? []) : [];
const shouldShowSplitShare = isBillSplit && !!requestAmount && requestAmount > 0 && participantAccountIDs.includes(getCurrentUserAccountID());

App/src/libs/TransactionPreviewUtils.ts

Line 324 in 6b934d1

const shouldShowSplitShare = isBillSplit && !!requestAmount && requestAmount > 0;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update createTransactionPreviewConditionals unit test to verify shouldShowSplitShare is only true if the user is a part of the split bill transaction.

What alternative solutions did you explore? (Optional)

We can return 0 here if the current user is not in participantAccountIDs

shouldShowSplitShare
    ? (transaction?.comment?.splits?.find((split) => split.accountID === sessionAccountID)?.amount ??
      (!participantAccountIDs.includes(sessionAccountID ?? 0)
          ? 0
          : calculateAmount(
                isReportAPolicyExpenseChat ? 1 : participantAccountIDs.length - 1,
                requestAmount ?? 0,
                requestCurrency ?? '',
                action?.actorAccountID === sessionAccountID,
            )))
    : 0,

App/src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx

Lines 146 to 152 in 6b934d1

	const splitShare = useMemo(
	() =>
	shouldShowSplitShare
	? (transaction?.comment?.splits?.find((split) => split.accountID === sessionAccountID)?.amount ??
	calculateAmount(isReportAPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount ?? 0, requestCurrency ?? '', action?.actorAccountID === sessionAccountID))
	: 0,
	[

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021938303481336886209

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[melvin-bot]

@ahmedGaber93 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ahmedGaber93]

reviewing today