[$250] Expense - Error after holding expense and approving unheld expense as vacation delegate

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.71-8
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #61845
Email or phone of affected tester (no customers): sdnjoidsjosdjsojo2@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Invite User B to the workspace.
4. Go to Account > Status > Vacation delegate.
5. Add User B as vacation delegate and click Save.
6. Go to workspace chat.
7. Submit an expense to the workspace chat.
8. Click Submit on the expense preview.
9. As User B, open the expense report.
10. Click More > Split > Save.
11. Refresh the page.
12. Open any expense row.
13. Click More > Hold > Enter reason and save it.
14. Close the RHP.
15. Click Approve.
16. Approve only the pending amount.
17. Dismiss the error.

Expected Result:

In Step 16, no error will show up after approving only the pending amount.

Actual Result:

In Step 16, error shows up after approving only the pending amount.
In Step 17, after dismissing the error, the unheld expense is approved.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6870627_1750940011061.20250626_201024.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021938657491960233700
• Upwork Job ID: 1938657491960233700
• Last Price Increase: 2025-07-18

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @deetergp

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[dangrous]

So this is a new feature and it doesn't look like there were any changes to the backend related to it in this deploy. I'm going to remove the DeployBlocker label (but keep DeployBlockerCash) so it won't block our deploy. Also cc @deetergp since I think you're looking at these ones?