[Due for payment 2025-08-13] [$250] User Settings-Undefined is stated instead of vacation delegate email

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.71-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #61845
Email or phone of affected tester (no customers): agexptest+pr2406a@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 15
App Component: User Settings

Action Performed:

Precondition: Have a workspace with workflows enabled and an Approver user set.
The Approver user has set a vacation delegate who is not a workspace member.
The submitter can be the admin user or an employee.

1. Go to staging.new.expensify.com
2. Log in with the workspace admin
3. Submit a manual expense to the workspace
4. Go to the expense details (refresh if the system message in the chat is not shown)

Expected Result:

A system message appears in the chat stating the vacation delegate's email after "sent this report to..."

Actual Result:

The system message contains "undefined" instead of stating the vacation delegate's email.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6869039_1750815265314.Undefined_vacation_delegate.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937914530637304542
• Upwork Job ID: 1937914530637304542
• Last Price Increase: 2025-08-14

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User Settings-Undefined is stated instead of vacation delegate email

What is the root cause of that problem?

We currently have a type:

App/src/languages/params.ts

Line 382 in 014edee

type DelegateSubmitParams = {delegateUser: string; originalManager: string};

which has delegateUser in it, but in fact we get the delegate field from the backend:

What changes do you think we should make in order to solve the problem?

There are 2 ways to solve the problem:

1. Fix the field name on the backend, in this case you will not have to fix anything on the frontend

2. Change the name of the field to delegate, then display this field (Perhaps on accounts that already had delegate users, the delegateUser field still comes, so you will need to take this into account here as well)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[rushatgabhane]

@deetergp this message should not be sent to newDot, this is a oldDot message right?

Or maybe we should handle this on frontend and display it properly.

happens for vacation delegates that are not on the workspace