[Due for payment 2025-07-04] [$250] Expense- Missing negative sign on expense action buttons, negative expense can be paid offline

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.71-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #56092
Email or phone of affected tester (no customers): jsdoijsnodi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense with negative amount.
4. Click + > Create report.
5. Go offline.
6. Open the first expense report from Step 3.
7. Click Report field.
8. Select the report from Step 4.
9. Go back to main workspace chat.
10. Click Submit, Approve and Pay elsewhere.
11. Go online.
12. Open transaction thread.

Expected Result:

In Step 10,

• Submit and Approve button will show negative sign when moving expense with negative amount in offline mode.
• Pay button will not show up because the expense is negative so it cannot be paid.

Actual Result:

In Step 10,

• Submit and Approve button does not show negative sign when moving expense with negative amount in offline mode.
• Pay button shows up when the expense is negative and it can be paid.

In Step 12, after returning online, error shows up from paying the negative expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6868956_1750807286156.20250625_071707.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937960635280924353
• Upwork Job ID: 1937960635280924353
• Last Price Increase: 2025-06-25

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit and Approve button does not show negative sign when moving expense with negative amount in offline mode.
Pay button shows up when the expense is negative and it can be paid.

After returning online, error shows up from paying the negative expense.

What is the root cause of that problem?

The reason is that we're getting the transactionAmount without isFromExpenseReport param, then by default this function always returns the positive amount, which causes the total to be incorrect in offline

App/src/libs/actions/Transaction.ts

Lines 683 to 689 in 014edee

	const transactionAmount = getAmount(transaction);
	if (oldReport) {
	updatedReportTotals[oldReportID] = (updatedReportTotals[oldReportID] ? updatedReportTotals[oldReportID] : (oldReport?.total ?? 0)) + transactionAmount;
	}
	if (reportID) {
	updatedReportTotals[reportID] = (updatedReportTotals[reportID] ? updatedReportTotals[reportID] : (newReport.total ?? 0)) - transactionAmount;
	}

What changes do you think we should make in order to solve the problem?

We should pass isFromExpenseReport parameter to getAmount function

const transactionAmount = getAmount(transaction, isExpenseReport(oldReport));

App/src/libs/actions/Transaction.ts

Lines 683 to 689 in 014edee

	const transactionAmount = getAmount(transaction);
	if (oldReport) {
	updatedReportTotals[oldReportID] = (updatedReportTotals[oldReportID] ? updatedReportTotals[oldReportID] : (oldReport?.total ?? 0)) + transactionAmount;
	}
	if (reportID) {
	updatedReportTotals[reportID] = (updatedReportTotals[reportID] ? updatedReportTotals[reportID] : (newReport.total ?? 0)) - transactionAmount;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update changeTransactionsReport test and verify that the total of the new report is updated correctly with the negative amount transaction.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.