[Due for payment 2025-07-04] Expense - Amount change system message appears when amount is saved without edit

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.71-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #56092
Email or phone of affected tester (no customers): jsndojdsosjdo@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Account has self DM.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a manual expense.
4. Click on the expense preview.
5. Click Amount.
6. Without editing the amount, click Save.

Expected Result:

There will be no system message for amount change when the amount is saved without edit.

Actual Result:

System message for amount change shows up every time the amount is saved without edit.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6868836_1750799044445.20250625_025113.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Valforte (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Valforte]

Offending PR is likely #56092 This bug is very minor as it only affect self DM so I'm ok demoting it, still needs to be fixed

can you take a look @pasyukevich ?

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Amount change system message appears when amount is saved without edit

What is the root cause of that problem?

• When we track an expense we return absolute value by removing - from amount

App/src/libs/TransactionUtils/index.ts

Lines 564 to 570 in 0dc8bd5

	if ((!isFromExpenseReport || isFromTrackedExpense) && !allowNegative) {
	const amount = transaction?.modifiedAmount ?? 0;
	if (amount) {
	return Math.abs(amount);
	}
	return Math.abs(transaction?.amount ?? 0);
	}

But for expense reports we store the amount with opposite sign (plus value)

App/src/libs/TransactionUtils/index.ts

Lines 576 to 582 in 0dc8bd5

	// Expense report case:
	// The amounts are stored using an opposite sign and negative values can be set,
	// we need to return an opposite sign than is saved in the transaction object
	let amount = transaction?.modifiedAmount ?? 0;
	if (amount) {
	return -amount;
	}

then inside IOURequestStepAmount

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Lines 277 to 280 in 0dc8bd5

	if (newAmount === getAmount(currentTransaction, false, false, true, !allowNegative) && currency === transactionCurrency) {
	navigateBack();
	return;
	}

we check if newAmount and currentTransaction is same but since newAmount was store as negative value and inside getAmount we remove the negative sign from track expense report that does not pass this check due to different sign with values

and we end up calling this function that make the lastAction MODIFIED_EXPENSE

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 295 in 0dc8bd5

updateMoneyRequestAmountAndCurrency({

What changes do you think we should make in order to solve the problem?

We should only consider the value by checking only absolute values that make sure if newAmount and transaction?.amount are same we don't call updateMoneyRequestAmountAndCurrency function

if (Math.abs(newAmount) === Math.abs(getAmount(currentTransaction, false, false, true, !allowNegative))) {
    navigateBack();
    return;
}

here

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Lines 277 to 280 in 0dc8bd5

	if (newAmount === getAmount(currentTransaction, false, false, true, !allowNegative) && currency === transactionCurrency) {
	navigateBack();
	return;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

we can explicitly check if it's Track expense report and apply math.abs on those reports only

const transactionAmount = getAmount(currentTransaction, false, false, true, !allowNegative);
const isTrackExpenseReport = isTrackExpenseReportUtil(report);

const isSameAmount = isTrackExpenseReport
    ? Math.abs(newAmount) === Math.abs(transactionAmount)
    : newAmount === transactionAmount;

if (isSameAmount && currency === transactionCurrency) {
    navigateBack();
    return;
}

here

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Lines 277 to 280 in 0dc8bd5

	if (newAmount === getAmount(currentTransaction, false, false, true, !allowNegative) && currency === transactionCurrency) {
	navigateBack();
	return;
	}