[Hold for payment 2025-07-09] [$250] Green spinner loads infinitely when offline, and “offline” indicator flickers

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.69-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Open the app with an internet connection
2. Navigate to 'Reports"
3. Disconnect from the internet
4. Observe the green spinner and offline indicator behavior

Expected Result:

The green loader shouldn’t keep going if I’m in a known offline state,
The offline indicator should stay consistently visible until the network is restored

Actual Result:

When the app is offline, the green loading remains visible and loads indefinitely, suggesting a pending action or fetch. Simultaneously, the “offline” indicator intermittently flickers—appearing and disappearing—rather than remaining stable.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

ScreenRecording_06-23-2025.13-42-45_1.MP4

ScreenRecording_06-23-2025.13-14-21_1.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021938321446379213534
• Upwork Job ID: 1938321446379213534
• Last Price Increase: 2025-07-03
• Automatic offers:
• truph01 | Contributor | 107959905

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Green spinner loads infinitely when offline, and “offline” indicator flickers

What is the root cause of that problem?

• The loading bar is always shown whenever isLoadingReportData is true, regardless of the app’s network status:

App/src/components/Navigation/TopBar.tsx

Line 66 in 16a58b5

<LoadingBar shouldShow={(isLoadingReportData ?? false) || shouldShowLoadingBar} />

What changes do you think we should make in order to solve the problem?

• We should update the condition that controls the loading bar visibility to ensure it's only displayed when the app is online. Proposed update:

    <LoadingBar shouldShow={(!isOffline && (isLoadingReportData ?? false)) || shouldShowLoadingBar} />

or

            <LoadingBar shouldShow={((isLoadingReportData ?? false) || shouldShowLoadingBar) && !isOffline} />

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021938321446379213534

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

What about the offline indicator flickering @truph01?