[$250] Track expense - Unable to delete track scan expense while scanning

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.70-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

1. Open https://staging.new.expensify.com
2. Navigate to the self DM
3. Create a scan expense
4. Click on this expense while it's still scanning
5. Click on More
6. Click Delete

Expected Result:

This expense should be deleted

Actual Result:

This expense isn't deleted

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937302120868579148
• Upwork Job ID: 1937302120868579148
• Last Price Increase: 2025-07-01

Issue Owner

Current Issue Owner: @amyevans

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ryntgh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - Unable to delete track scan expense while scanning

What is the root cause of that problem?

When calling deleteTrackExpense, report?.chatReportID passes undefined for scan expenses that are still processing in Self DM

App/src/components/MoneyRequestHeader.tsx

Lines 329 to 334 in 02e37d7

	if (isTrackExpenseAction(parentReportAction)) {
	deleteTrackExpense(report?.chatReportID, transaction.transactionID, parentReportAction, true);
	} else {
	deleteMoneyRequest(transaction.transactionID, parentReportAction, true);
	removeTransaction(transaction.transactionID);
	}

When a receipt is still scanning, the transaction thread report chatReportID property is undefined, while the parent Self DM report reportID is already available. Once scanning completes, both values become the same

Currently, we call deleteTrackExpense with undefined as the first parameter, so it cannot properly identify the Self DM chat report to update, causing the function to fail to trigger DeleteMoneyRequest

This behavior also occurs with distance expenses when the route is not defined, and when creating and deleting a manual expense in offline mode. When returning online, the report is not deleted because report?.chatReportID passes undefined

What changes do you think we should make in order to solve the problem?

Update the deleteTrackExpense call to use parentReport?.reportID instead of report?.chatReportID

                    if (isTrackExpenseAction(parentReportAction)) {
                        deleteTrackExpense(parentReport?.reportID, transaction.transactionID, parentReportAction, true);

App/src/components/MoneyRequestHeader.tsx

Lines 329 to 330 in 02e37d7

	if (isTrackExpenseAction(parentReportAction)) {
	deleteTrackExpense(report?.chatReportID, transaction.transactionID, parentReportAction, true);

This ensures that the correct Self DM chat report ID is always passed to deleteTrackExpense, regardless of whether the scan is still in progress or completed

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Or we can use report?.parentReportID

                    if (isTrackExpenseAction(parentReportAction)) {
                        deleteTrackExpense(report?.parentReportID, transaction.transactionID, parentReportAction, true);

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

This expense isn't deleted

What is the root cause of that problem?

The report?.chatReportID is undefined so this function do nothing.

App/src/components/MoneyRequestHeader.tsx

Lines 329 to 334 in 02e37d7

	if (isTrackExpenseAction(parentReportAction)) {
	deleteTrackExpense(report?.chatReportID, transaction.transactionID, parentReportAction, true);
	} else {
	deleteMoneyRequest(transaction.transactionID, parentReportAction, true);
	removeTransaction(transaction.transactionID);
	}

report?.chatReportID is undefined because we don't add this in the optimistic data of the transaction thread report. If we open the transaction thread report, the OpenReport API will return chatReportID is the parent report

App/src/libs/ReportUtils.ts

Line 7764 in b8ef627

const transactionThread = buildTransactionThread(iouAction, iouReport, existingTransactionThreadReportID);

App/src/libs/ReportUtils.ts

Lines 7702 to 7710 in b8ef627

	return buildOptimisticChatReport({
	participantList: participantAccountIDs,
	reportName: getTransactionReportName({reportAction}),
	policyID: moneyRequestReport?.policyID,
	ownerAccountID: CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
	notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
	parentReportActionID: reportAction?.reportActionID,
	parentReportID: moneyRequestReport?.reportID,
	});

What changes do you think we should make in order to solve the problem?

From what I see, the chatReportID is the same as parentReportID, then we can add chatReportID when we create the optimistic chat report here

chatReportID: parentReportID,

App/src/libs/ReportUtils.ts

Lines 6916 to 6918 in b8ef627

	const optimisticChatReport: OptimisticChatReport = {
	type: CONST.REPORT.TYPE.CHAT,
	chatType,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update buildOptimisticChatReport unit test to verify the chatReportID exists if parentReportID is not empty.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021937302120868579148

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)