[HOLD #64326] [$250] Multi tags - Both "Don't require" and "Require tags" button have a checkmark icon

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.67-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #63752
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Independent tags are imported to the workspace.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags.
3. Mark at least one tag as Required and the other as Not required (by changing the toggle button).
4. Select all the main tags via checkbox.
5. Click dropdown button.

Expected Result:

"Don't require" button will have an X icon, "Require tags" button will have a checkmark icon.

Actual Result:

Both "Don't require" and "Require tags" button have a checkmark icon.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

Bug6862546_1750165384496!Independent.-.Multi.Level.tags.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937921726274608833
• Upwork Job ID: 1937921726274608833
• Last Price Increase: 2025-06-25

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[vincdargento]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-17 13:59:53 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Multi tags - Both "Don't require" and "Require tags" button have a checkmark icon

What is the root cause of that problem?

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 509 to 512 in ebe331e

	if (requiredTagCount > 0 && !hasDependentTags && isMultiLevelTags) {
	options.push({
	icon: Expensicons.Checkmark,
	text: translate('workspace.tags.notRequireTags'),

we are using checkmark icon here for Don't require option same as Require tags.

What changes do you think we should make in order to solve the problem?

We should update this to Close icon

      icon: Expensicons.Close

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lakchote]

Demoting since it's not a blocker but a minor UI bug. Looks like it might come from #63752 cc @Valforte @akinwale @allgandalf