[Ready for payment] [$250] Scan-After selecting a corrupt file, the camera is deactivated

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.67-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6286833
Email or phone of affected tester (no customers): agexptest+pr1606.2@gmail.com, applausetester+ag1606.2@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung S23FE/ Android 15
App Component: Money Requests

Action Performed:

Precondition: Have a scan expense in a workspace.
The Expensify Hybrid app has camera permission enabled.

1. Open the Expensify Hybrid app
2. Log in with any account as admin or employee
3. Go to any scan expense details
4. Tap the receipt preview
5. Tap on the three-dot menu > Replace > Image icon > Choose file
6. Select a corrupted PDF file
7. Note that the attachment error is shown, and the background turns black
8. Tap Ok
9. Tap the green circle button
10. Tap the back arrow at the top left
11. Note that a camera error message is shown before go back to the expense details

Expected Result:

After step 7, the camera remains activated in the background. The user can repeat the file selection.
If there is an issue with the camera, an error message will appear immediately after tapping the green circle button.

Actual Result:

After trying to upload a corrupt file, the camera is deactivated. After tapping the back arrow, the camera error message is displayed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6862105_1750118475193.camera_deactivated.mp4

Corrupted PDF.pdf

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021935841655617073597
• Upwork Job ID: 1935841655617073597
• Last Price Increase: 2025-06-19
• Automatic offers:
• dominictb | Reviewer | 107779728
• nyomanjyotisa | Contributor | 107779729

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[RachCHopkins]

@mitarachim do you have a corrupt PDF file I can triage with?

[mitarachim]

Hello @RachCHopkins , sorry i forgot to attach.
we can use below corrupted files (pdf and jpg)

Corrupted PDF.pdf

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan-After selecting a corrupt file, the camera is deactivated

What is the root cause of that problem?

When a corrupted PDF file is selected through the AttachmentPicker, the onClosed callback is executed which only sets setIsLoaderVisible(false), but we did not reset the didCapturePhoto state variable that controls camera activation

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines 893 to 895 in 7b6e4e1

	onClosed: () => {
	setIsLoaderVisible(false);
	},

When file selection fails due to corruption, the didCapturePhoto state is never reset causing the state remains true, which prevents further camera operations

What changes do you think we should make in order to solve the problem?

We could reset the didCapturePhoto state by setting it to false to ensure the camera remains available for further operations

                                        onClosed: () => {
                                            setIsLoaderVisible(false);
                                            setDidCapturePhoto(false);
                                        },

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines 893 to 895 in 7b6e4e1

	onClosed: () => {
	setIsLoaderVisible(false);
	},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[RachCHopkins]

Can repro!