[Due for payment 2025-07-04] [$250] Expense - "Deleted report" is shown when admin opens member's workspace chat after app reset

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sdjdiosnjdois112j@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workflows feature is disabled.
• Admin invites member to the workspace.

1. Go to staging.new.expensify.com
2. [Member] Go to workspace chat.
3. [Member] Submit an expense to the workspace chat.
4. [Admin] Send a message to another chat which is not workspace chat with member.
5. [Admin] Go to Account > Troubleshoot.
6. [Admin] Click Clear cache and restart > Reset and refresh (or log out and log in again).
7. [Admin] Open workspace chat with member.

Expected Result:

Expense preview will be displayed when opening workspace chat with member after app reset (or relogin).

Actual Result:

"Deleted report" is displayed when opening workspace chat with member after app reset (or relogin).

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021933535512261363593
• Upwork Job ID: 1933535512261363593
• Last Price Increase: 2025-06-13
• Automatic offers:
• nkdengineer | Contributor | 107710182

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021933535512261363593

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Deleted report" is displayed when opening workspace chat with member after app reset (or relogin).

What is the root cause of that problem?

When another report is opened firstly, the transaction list doesn't contain the in the member's workspace. After we open the member's workspace, the OpenReport API will return the iouReport, transaction data.

But the ReportActionItem isn't subscribed to the transactions from Onyx, the isClosedExpenseReportWithNoExpenses returns true when the iouReport data is available and this component isn't re-rendered again after the transaction data is updated.

App/src/pages/home/report/ReportActionItem.tsx

Line 112 in b5e0cb8

isClosedExpenseReportWithNoExpenses={isClosedExpenseReportWithNoExpenses(iouReport)}

App/src/libs/ReportUtils.ts

Lines 1932 to 1944 in b5e0cb8

	function hasExpenses(reportID?: string, transactions?: SearchTransaction[]): boolean {
	if (transactions) {
	return !!transactions?.find((transaction) => transaction?.reportID === reportID);
	}
	return !!Object.values(allTransactions ?? {}).find((transaction) => transaction?.reportID === reportID);
	}
	/**
	* Whether the provided report is a closed expense report with no expenses
	*/
	function isClosedExpenseReportWithNoExpenses(report: OnyxEntry<Report>, transactions?: SearchTransaction[]): boolean {
	return report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED && isExpenseReport(report) && !hasExpenses(report.reportID, transactions);
	}

As a result, the Deleted report appears

App/src/pages/home/report/PureReportActionItem.tsx

Lines 908 to 910 in b5e0cb8

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && isClosedExpenseReportWithNoExpenses) {
	children = <RenderHTML html={`<deleted-action>${translate('parentReportAction.deletedReport')}</deleted-action>`} />;
	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW) {

What changes do you think we should make in order to solve the problem?

We should subscribe to the transactions in ReportActionItem. To better performance, we should subscribe it from ReportActionsList and pass it down to ReportActionItem. And then pass transactions to isClosedExpenseReportWithNoExpenses function here.

App/src/pages/home/report/ReportActionItem.tsx

Line 112 in b5e0cb8

isClosedExpenseReportWithNoExpenses={isClosedExpenseReportWithNoExpenses(iouReport)}

Note: The Deleted Report still appears briefly with this fix, to fix that the backend should return the transactions data before the iouReport data.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dukenv0307]

@nkdengineer's proposal looks good to me

[dukenv0307]

🎀👀🎀 C+ reviewed