[hold for payment 2025-07-07] [$250] Reports - In employee workspace chat, report created is not scrolled to bottom

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9 1.63-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): slottwo1@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Workspace Settings

Action Performed:

1. Launch app
2. Go to workspace settings - invite a member
3. Go to https://staging.new.expensify.com/home
4. Login as invited member
5. Open employee workspace chat
6. Create a report in offline(wait till no internet connection on header)

Expected Result:

In employee workspace chat, report created must be scrolled to bottom in offline.

Actual Result:

In employee workspace chat, report created is not scrolled to bottom in offline.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021934981418913953210
• Upwork Job ID: 1934981418913953210
• Last Price Increase: 2025-06-17
• Automatic offers:
• dominictb | Reviewer | 107780772
• FitseTLT | Contributor | 107780773

Issue Owner

Current Issue Owner: @madmax330

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-10 17:50:40 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - In employee workspace chat, report created is not scrolled to bottom

What is the root cause of that problem?

Because we are not updating the lastVisibleActionCreated of the parent report to the report preview created optimistically here

App/src/libs/actions/Report.ts

Lines 2723 to 2725 in a3e39d2

	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`,
	value: {[reportActionID]: optimisticCreateAction},

it wil early return here before scroll to bottom because hasNewestReportActionRef will be false

App/src/pages/home/report/ReportActionsList.tsx

Lines 417 to 424 in a3e39d2

	if (!hasNewestReportActionRef.current) {
	if (Navigation.getReportRHPActiveRoute()) {
	return;
	}
	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	});
	return;

What changes do you think we should make in order to solve the problem?

We need to set the lastVisibleActionCreated to report preview action created

        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${parentReport?.reportID}`,
            value: {lastVisibleActionCreated: optimisticReportPreview.created},
        },

We should revert the value on failureData

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

If needed we can assert createNewReport updates the parent report lastVisibleActionCreated properly.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@slafortune Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021934981418913953210

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)