"Please sign in again" link does not redirect

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.63-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #63547
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Other

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Send this link into any chat: http://www.staging.new.expensify.com/transition?
4. Tap on the link > Tap on "Please sign in again" link

Expected Result:

User expects to be redirected to sign in page

Actual Result:

Nothing happens, no redirection

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6855156_1749523617270.No_redirection_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens, no redirection

What is the root cause of that problem?

Because when clicking on the link, it navigates using Navigation.goBack, and since there is nowhere to go back to, nothing will happen

App/src/pages/ErrorPage/SessionExpiredPage.tsx

Lines 37 to 41 in efec20a

	if (!CONFIG.IS_HYBRID_APP) {
	clearSignInData();
	Navigation.goBack();
	return;
	}

What changes do you think we should make in order to solve the problem?

Replace Navigation.goBack with navigation to the signIn route.

Navigation.navigate(ROUTES.HOME, {forceReplace: true});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens, no redirection

What is the root cause of that problem?

We have the logic to goBack after clearing Onyx data when users press Please sign in again

App/src/pages/ErrorPage/SessionExpiredPage.tsx

Line 39 in 74fc9b9

Navigation.goBack();

but Navigation.goBack can't be executed

What changes do you think we should make in order to solve the problem?

Change it to

Navigation.isNavigationReady().then(() => {
                                        // We must call goBack() to remove the /transition route from history
                                        Navigation.goBack();
                                        Navigation.navigate(ROUTES.HOME);
                                    });

like what we did in

App/src/pages/signin/SAMLSignInPage/index.native.tsx

Lines 79 to 83 in 74fc9b9

	Navigation.isNavigationReady().then(() => {
	// We must call goBack() to remove the /transition route from history
	Navigation.goBack();
	Navigation.navigate(ROUTES.HOME);
	});

We can add Navigation.navigate(ROUTES.HOME); or not.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Please sign in again" link does not redirect

What is the root cause of that problem?

we use go back, and the link is opened in new tab so it is unable to go back

App/src/pages/ErrorPage/SessionExpiredPage.tsx

Lines 35 to 46 in 74fc9b9

	<TextLink
	onPress={() => {
	if (!CONFIG.IS_HYBRID_APP) {
	clearSignInData();
	Navigation.goBack();
	return;
	}
	HybridAppModule.closeReactNativeApp({shouldSignOut: true, shouldSetNVP: false});
	}}
	>
	{translate('deeplinkWrapper.signIn')}
	</TextLink>

What changes do you think we should make in order to solve the problem?

use Navigation.goBack(ROUTES.HOME); instead

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[joekaufmanexpensify]

This looks related to #63547, which was just merged yesterday. @jayeshmangwani @ZhenjaHorbach @marcochavezf could you take a look?

[jayeshmangwani]

@joekaufmanexpensify it's happening on the production version too, so I don't think it's related to the linked PR. I was also able to reproduce the issue while testing that PR.

[joekaufmanexpensify]

Got it. I asked a follow up question here to better understand what is happening with this issue.

[joekaufmanexpensify]

Bumped in slack

[joekaufmanexpensify]

Still discussing

[joekaufmanexpensify]

We discussed this here and decided to close for now because the only way someone could land on this page is if they manually entered the transition link without a token in it, which we don't think is an action any real user would ever realistically take. We will revisit this if a real user ever experiences this. 👍