[Due for payment 2025-07-18] [$250] Workspace - "Go to workspace" on invited workspace chat opens not here page after app reset

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dsndosuihiuhisu@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is invited to a workspace

1. Go to staging.new.expensify.com
2. Create another workspace
3. Go to the created workspace settings > Workflows
4. Go to Account > Troubleshoot
5. Click Clear cache and restart
6. Click Reset and refresh
7. Go to Inbox
8. Click on the workspace chat of the invited workspace (from precondition)
9. Click on the chat header
10. Click Go to workspace

Expected Result:

Workspace settings page will open

Actual Result:

Not here page opens

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6851355_1749118360557.20250605_180231.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021932419116025619202
• Upwork Job ID: 1932419116025619202
• Last Price Increase: 2025-06-17
• Automatic offers:
• truph01 | Contributor | 107747594

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - "Go to workspace" on invited workspace chat opens not here page after app reset

What is the root cause of that problem?

When pressing go to workspace we are navigated to workspace initial page

App/src/pages/ReportDetailsPage.tsx

Line 481 in 0312361

Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(report?.policyID, Navigation.getActiveRoute()));

then if it is wide screen the last accessed workspace feature page will open on central pane
but in this case as we are not admin and it is navigating to workflow screen of the workspace so we see not found
And the use effect here only redirects if the feature is disabled

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 172 in 0312361

Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));

but in this case policy.isWorkflowsEnabled is true it is just that the user is not admin

What changes do you think we should make in order to solve the problem?

We need to have a redirecting added to the AccessOrNotFoundWrapper when a user has no access to the feature page.
We can add a new effect but we can also reuse the current one to navigate to the overview page if they are navigated to features that they don't have access (protected screens and they are not admin). So we can update isFeatureEnabled to also incorporate the inaccessible page case too

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 152 in 0312361

const isFeatureEnabled = featureName ? isPolicyFeatureEnabledUtil(policy, featureName) : true;

const isFeatureEnabled = featureName
        ? isPolicyFeatureEnabledUtil(policy, featureName) && (!accessVariants.includes(CONST.POLICY.ACCESS_VARIANTS.ADMIN) || isPolicyAdmin(policy, login))
        : true;

but we need to start navigating to overview page if the user is not admin

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 172 in 0312361

Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));

 Navigation.isNavigationReady().then(() =>
            Navigation.goBack(isPolicyAdmin(policy, login) ? ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID) : ROUTES.WORKSPACE_OVERVIEW.getRoute(policyID)),
        );

But we need to ensure all the pages have properly passed the access variants admin for instance here we missed adding it

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 369 in 0312361

featureName={CONST.POLICY.MORE_FEATURES.ARE_WORKFLOWS_ENABLED}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[truph01]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-11 13:51:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When a user receives a workspace chat invitation and clicks "Go to workspace" after an app reset, they are redirected to a "Not here" page instead of the correct workspace page.

What is the root cause of that problem?

• The navigation triggered by the "Go to workspace" action takes the user to the workspace's initial page in the LHN:
  

  App/src/pages/ReportDetailsPage.tsx

  Line 481 in 0312361

  Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(report?.policyID, Navigation.getActiveRoute()));

• At the same time, the central panel attempts to restore the last stored screen the user accessed—in this case, /workflows:

• App/src/libs/Navigation/AppNavigator/createSplitNavigator/SplitRouter.ts

  Lines 86 to 89 in df3cd38

  	state.routes.push({
  	name: previousSelectedCentralScreen ?? defaultCentralScreen,
  	params: state.routes.at(0)?.params,
  	});

• If the current user is only a member and not an admin, they do not have access to /workflows. As a result, the central panel displays a "Not here" page, leading to a confusing and broken experience.

What changes do you think we should make in order to solve the problem?

• We considered updating the logic in the SplitRouter here:
  

  App/src/libs/Navigation/AppNavigator/createSplitNavigator/SplitRouter.ts

  Lines 86 to 89 in df3cd38

  	state.routes.push({
  	name: previousSelectedCentralScreen ?? defaultCentralScreen,
  	params: state.routes.at(0)?.params,
  	});

• The idea is to check whether the previousSelectedCentralScreenPolicyID matches the routePolicyID of the workspace being navigated to. If they differ, we should avoid restoring the previously selected central screen, since it may not be accessible in the new policy context (e.g., /workflows for non-admins).

if (previousSelectedCentralScreenPolicyID === routePolicyID) {
    state.routes.push({
        name: previousSelectedCentralScreen ?? defaultCentralScreen,
        params: state.routes.at(0)?.params,
    });
} else {
    state.routes.push({
        name: defaultCentralScreen,
        params: state.routes.at(0)?.params,
    });
}

• This approach would ensure that the user always lands on a valid screen when navigating between workspaces with different permission levels.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)

• We should update the navigation logic at the following location:
  

  App/src/pages/ReportDetailsPage.tsx

  Line 481 in 0312361

  Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(report?.policyID, Navigation.getActiveRoute()));

if (isSmallScreenWidth) {
    Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(report?.policyID, Navigation.getActiveRoute()));
} else {
    Navigation.navigate(ROUTES.WORKSPACE_OVERVIEW.getRoute(report?.policyID));
}

It will navigate user to workspace overview page in large screen.

• Optional: We can always direct the user to WORKSPACE_OVERVIEW, regardless of screen size:

Proposed change:

Navigation.navigate(ROUTES.WORKSPACE_OVERVIEW.getRoute(report?.policyID));

This ensures a consistent and accessible landing page for all users.

[melvin-bot]

@zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021932419116025619202

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)