Hold expense - After approving the pending amount, the expense report is empty

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.59-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6206790
Email or phone of affected tester (no customers): sdjonsjdosdjodi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses to workspace chat.
4. Click on the expense preview.
5. Click on any expense row.
6. Click More > Hold.
7. Enter reason and save it.
8. Close the RHP.
9. Click Submit.
10. Click Approve.
11. Approve the pending (unheld) amount.

Expected Result:

After approving the pending amount, the expense report will show the expense thread of the unheld expense.

Actual Result:

After approving the pending amount, the expense report is empty.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6850979_1749077177883.20250605_064330.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[BlameGPT]

Possible culprit PRs for this issue

• [CP Stag] Revert "Fix the pending (unheld) approve amount when other expenses are held" #63315: The PR directly relates to fixing the pending (unheld) approve amount when other expenses are held, matching the issue's flow of holding expenses and approving pending amounts.
• [Better Expense Report View] Generalise SearchContext + #61777 follow-up #62472: This PR involves holding expenses and the related UI flows in the MoneyRequestReport page, closely matching the issue's steps involving holding expenses and submitting/approving them.
• fix: RBR Hold Message #63129: This PR fixes the hold message display on expense reports, which is part of the hold expense flow described in the issue.

[thienlnam]

Similar to #63502, I wasn't able to reproduce on main - so it might have been fixed in the same PR that is getting CPed #63502 (comment)