[Due for payment 2025-07-04] Expense Report - User is unable to reopen expense report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @VictoriaExpensify
Slack conversation (hyperlinked to channel name): #expensify_retain

Action Performed:

Precondition: you have to navigate to Classic to Undo Closed reports if they were created before Delayed Submit was enabled.
Make sure Delayed Submit is disabled on the workspace

1. Create expenses
2. Expenses will auto-submit
3. Enable Delayed Submit
4. Go to Expense Reports > Click on the header of one of the expense reports created before Delayed Submit was enabled > More

Expected Result:

User should be able to reopen the expense report

Actual Result:

User is unable to reopen expense report

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.3141.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User can't reopen report.

What is the root cause of that problem?

From the OP steps, there is a step missing, that is the approval is disabled. When the approval is disabled, we don't show the undo option.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 454 to 461 in 437acdd

	const isSubmitAndClose = isSubmitAndCloseUtils(policy);
	// This should be removed after we change how instant submit works
	const isInstantSubmit = isInstantSubmitEnabled(policy);
	if (!isExpenseReport || isSubmitAndClose || isInstantSubmit) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

If we want to allow undo submit even when approval is disabled (which I think make sense), then we can remove the isSubmitAndClose close check from isRetractAction. (tested it and BE allows it)

(or we can update it based on the requirements)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can update test getSecondaryReportActions so that it returns the retract action for submitted report even though the approval is disabled.

[lydiabarclay]

Just want to run this one by @Expensify/product!

[trjExpensify]

@rushatgabhane can you look into it as follow-up to this?

If I execute the below steps, the Undo submit button appears:

1. Disable delayed submission + disable approvals
2. Create an expense
3. Check the secondary action menu, no option to Undo submit or Undo close as expected
4. Enable delayed submission + enable approvals
5. Check the menu again, there's an option to Undo submit now as expected

Given that, I'd expect the same should be the case for Undo close when executing these steps:

1. Disable delayed submission + disable approvals
2. Create an expense
3. Check the secondary action menu, no option to Undo submit or Undo close as expected
4. Enable delayed submission only
5. Check the menu again, there should be an option to Undo close to take it back to open ❌

P.s - @lydiabarclay bit more commentary in this internal thread, but I think you'll want to move this to the #convert GH project to be tracked with that project that recently introduced this feature last week.

CC: @dangrous @joekaufmanexpensify for vis!

[rushatgabhane]

looking

[rushatgabhane]

this is a bit conflicting. if we change the settings, the report's state is not going to be updated.

the report was created when we had delayed submission and approvals disabled

[rushatgabhane]

This means Undo submit will be available on processing reports when:
Delay submissions and approvals are enabled, but payments are disabled.
Delay submissions, approvals, and payments are all enabled.
Delay submissions and payments are disabled, but approvals are enabled.
Delay submissions and approvals are disabled, but payments are enabled.
Delay submissions is disabled, but approvals and payments are enabled.

This condition isn't mentioned in the doc. Please correct me if I'm misunderstanding

https://docs.google.com/document/d/17GYxlzpfOJFs2YmCe7eEFDhrjq0h8DEEQm57_tjZ2aA/edit?tab=t.0#bookmark=id.624w9dlazr61

[trjExpensify]

This is the Undo close button logic:

[rushatgabhane]

There must be a misunderstanding.

The report will not be in Closed state. So it won't show undo close.

I get that we changed the policy, but the report was created before the change so it will not be affected.

Screen.Recording.2025-06-09.at.14.39.44.mov

[trjExpensify]

The report will not be in Closed state. So it won't show undo close.

If it's not in the Closed state, what state is it in? And if that's processing, then it should show Undo submit then shouldn't it?

I get that we changed the policy, but the report was created before the change so it will not be affected.

Why does Undo submit appear after changing the workspace settings just fine, but undo close does not?

The video below highlights testing these two cases. Can you see the diff between that Undo submit case and Undo close case?

2025-06-09_12-12-24.mp4