[C+ Checklist Needs Completion] [$125] Expense report - New message marker is not displayed on the first message in expense report

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.58-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause Internal Team
Device used: MacOS Chrome, Desktop
App Component: Chat Report View

Action Performed:

1. Navigate to workspace chat
2. Create two expenses
3. Click on Expense preview
4. Send a message in the expense report
5. Right click on the message > Mark as unread

Expected Result:

Green new message marker should be displayed on the message

Actual Result:

Green new message marker is not displayed on the first message

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6850408_1749028663284.Screen_Recording_2025-06-04_at_12.08.25_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021930954644665504569
• Upwork Job ID: 1930954644665504569
• Last Price Increase: 2025-06-13
• Automatic offers:
• nyomanjyotisa | Contributor | 107797830

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-04 15:02:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green new message marker is not displayed on the first message

What is the root cause of that problem?

In this condition

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Lines 320 to 327 in bead7ce

	const startIndex = visibleReportActions.length - 1;
	const endIndex = earliestReceivedOfflineMessageIndex ?? 0;
	// Scan through each visible report action until we find the appropriate action to show the unread marker
	for (let index = startIndex; index >= endIndex; index--) {
	const reportAction = visibleReportActions.at(index);
	const nextAction = visibleReportActions.at(index - 1);
	const isEarliestReceivedOfflineMessage = index === earliestReceivedOfflineMessageIndex;

While visibleReportActions's length is 1 => startIndex=0

it leads to us also having nextAction in here because [item].at(0) === [item].at(-1)

=> it'll return false in shouldDisplayNewMarkerOnReportAction function

App/src/pages/home/report/shouldDisplayNewMarkerOnReportAction.ts

Lines 60 to 62 in bead7ce

	if (!isCurrentMessageUnread || isNextMessageUnread) {
	return false;
	}

App/src/pages/home/report/shouldDisplayNewMarkerOnReportAction.ts

Line 45 in bead7ce

const isNextMessageUnread = !!nextMessage && isReportActionUnread(nextMessage, unreadMarkerTime);

What changes do you think we should make in order to solve the problem?

We should set nextAction to undefined if index=0

    const nextAction = index >= 1 ? visibleReportActions.at(index - 1) : undefined;

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Line 326 in bead7ce

const nextAction = visibleReportActions.at(index - 1);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense report - New message marker is not displayed on the first message in expense report

What is the root cause of that problem?

On here, if index is 0, which is the top message, the nextAction will be the last visibleReportActions, visibleReportActions.at(-1)

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Line 326 in e3560bc

const nextAction = visibleReportActions.at(index - 1);

Which it will return false here since isNextMessageUnread is true

App/src/pages/home/report/shouldDisplayNewMarkerOnReportAction.ts

Lines 60 to 62 in e3560bc

	if (!isCurrentMessageUnread || isNextMessageUnread) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

Set nextAction to undefined if the index is 0

const nextAction = index > 0 ? visibleReportActions.at(index - 1) : undefined;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[M00rish]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-04 13:24:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense report - New message marker is not displayed on the first message in expense report

What is the root cause of that problem?

no check for this case of first message, we end up returning false becasue isNextMessageUnread is true:

App/src/pages/home/report/shouldDisplayNewMarkerOnReportAction.ts

Lines 60 to 61 in 96c2335

	if (!isCurrentMessageUnread || isNextMessageUnread) {
	return false;

What changes do you think we should make in order to solve the problem?

In moneyreportactionlist :
NextAction is undefined if there's one action

const nextAction = index > 0 ? visibleReportActions.at(index - 1) : undefined;

But doing this alone will not be enough because isReportActionUnread will return false still because lastreadtime is always slightly bigger than action.created time :

 const scrollToBottomForCurrentUserAction = useCallback(
        (isFromCurrentUser: boolean, reportAction?: OnyxTypes.ReportAction) => {
            InteractionManager.runAfterInteractions(() => {
                setIsFloatingMessageCounterVisible(false);
                // Check if the added comment is the first one
            if (visibleReportActions.length === 0 && reportAction?.created) {
                setUnreadMarkerTime(DateUtils.subtractMillisecondsFromDateTime(reportAction.created,1000));
            }

                // If a new comment is added from the current user, scroll to the bottom, otherwise leave the user position unchanged
                if (!isFromCurrentUser || reportAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT) {
.....

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021930954644665504569

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)