[BACK BUTTON] [HOLD on #59245] [Reverted] [$250] Expense-Tapping device back button "more" modal shown briefly with inconsistent navigation

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.58-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): applausetester+gi@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

Pre-condition: Perform the steps in both mweb and android

1. Go to https://staging.new.expensify.com/home
2. Open a workspace chat with a manual expense
3. Tap more - add expense
4. Tap device back button

Expected Result:

In both mweb and android, tapping device back button must show consistent behaviour.

Actual Result:

In mweb, tapping device back button "more" modal shown briefly & directs to expense reports page.

In android, tapping device back button "more" modal shown briefly & remains in same expense details page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6850318_1749016912044.Screenrecorder-2025-06-04-11-24-21-284.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021930675091171577232
• Upwork Job ID: 1930675091171577232
• Last Price Increase: 2025-07-25
• Automatic offers:
• daledah | Contributor | 107614262

Issue Owner

Current Issue Owner: @borys3kk

Issue Owner

Current Issue Owner: @eVoloshchak

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In mweb, tapping device back button "more" modal shown briefly & directs to expense reports page.

What is the root cause of that problem?

We don't handle back button on MoneyReportHeader

App/src/components/MoneyReportHeader.tsx

Lines 943 to 958 in 087424f

	<ButtonWithDropdownMenu
	success={false}
	onPress={() => {}}
	onSubItemSelected={(item, index, event) => {
	if (!isSecondaryActionAPaymentOption(item)) {
	return;
	}
	onPaymentSelect(event, item.value, triggerKYCFlow);
	}}
	buttonRef={buttonRef}
	shouldAlwaysShowDropdownMenu
	customText={translate('common.more')}
	options={applicableSecondaryActions}
	isSplitButton={false}
	wrapperStyle={shouldDisplayNarrowVersion && [!primaryAction && styles.flex1]}
	/>

So in web platforms, pressing device back button will go back to previous page instead of closing modals

What changes do you think we should make in order to solve the problem?

We should add shouldHandleNavigationBack param to ButtonWithDropdownMenu, pass it down to PopoverMenu -> PopoverWithMeasuredContent. Then use shouldHandleNavigationBack here

App/src/components/MoneyReportHeader.tsx

Lines 943 to 958 in 087424f

	<ButtonWithDropdownMenu
	success={false}
	onPress={() => {}}
	onSubItemSelected={(item, index, event) => {
	if (!isSecondaryActionAPaymentOption(item)) {
	return;
	}
	onPaymentSelect(event, item.value, triggerKYCFlow);
	}}
	buttonRef={buttonRef}
	shouldAlwaysShowDropdownMenu
	customText={translate('common.more')}
	options={applicableSecondaryActions}
	isSplitButton={false}
	wrapperStyle={shouldDisplayNarrowVersion && [!primaryAction && styles.flex1]}
	/>

We should apply same fix to other ButtonWithDropdownMenu as well, for example the same bug happens with Add Expenses primary action also in MoneyReportHeader:

Screen.Recording.2025-06-04.at.15.30.50.mov

If we should fix this behaviour for all ButtonWithDropdownMenus, then we can simply default shouldHandleNavigationBack as true.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, Navigation issue

What alternative solutions did you explore? (Optional)

The main solution closes the menu when clicking back button. If we want to go back to the previous menu, we should make some more additional changes:

1. Add another prop for ButtonWithDropDownMenu and PopoverMenu: shouldHandleSubMenuNavigationBack, defaults false. Pass this prop as true in MoneyReportHeader

2. Modify onClose method in PopoverMenu to handle sub menu back behaviour if shouldHandleSubMenuNavigationBack is true:

App/src/components/PopoverMenu.tsx

Lines 403 to 407 in 26a9430

	onClose={() => {
	setCurrentMenuItems(menuItems);
	setEnteredSubMenuIndexes(CONST.EMPTY_ARRAY);
	onClose();
	}}

We'll use the logics here:

App/src/components/PopoverMenu.tsx

Lines 280 to 284 in 26a9430

	onPress={() => {
	setCurrentMenuItems(previousMenuItems);
	setFocusedIndex(-1);
	setEnteredSubMenuIndexes((prevState) => prevState.slice(0, -1));
	}}

            onClose={() => {
                if (enteredSubMenuIndexes.length > 0 && shouldHandleSubMenuNavigationBack) {
                    const previousMenuItems = getPreviousSubMenu();
                    setCurrentMenuItems(previousMenuItems);
                    setFocusedIndex(-1);
                    setEnteredSubMenuIndexes((prevState) => prevState.slice(0, -1));
                    return;
                }
                setCurrentMenuItems(menuItems);
                setEnteredSubMenuIndexes(CONST.EMPTY_ARRAY);
                onClose();
            }}

POC

Screen.Recording.2025-06-06.at.01.41.44.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021930675091171577232

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[zanyrenney]

Looks like we already have a proposal form @daledah , please could you review @eVoloshchak ?

[eVoloshchak]

Pretty straightforward, @daledah's proposal looks good to me!

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.