[Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Track expense - After submitting per diem expense, confirm page in self DM also becomes per diem expense

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.56-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+020630kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has per diem rates.
• Account has self DM.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Per diem.
4. Create a per diem expense.
5. Go to self DM.
6. Click + > Create expense > Manual.
7. Enter amount.
8. Click Next.

Expected Result:

The confirmation page will be a manual expense confirmation page.

Actual Result:

The confirmation page is per diem expense confirmation page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929972201414841468
• Upwork Job ID: 1929972201414841468
• Last Price Increase: 2025-06-03

Issue Owner

Current Issue Owner: @CortneyOfstad / @flaviadefaria

Issue Owner

Current Issue Owner: @CortneyOfstad / @flaviadefaria

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After submitting per diem expense in WS chat, starting a manual expense flow on self DM shows per diem confirm page.

What is the root cause of that problem?

When we create a per diem request on a WS, the selected tab is now per-diem. When we open the money request from self DM, money request initialization is called twice.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 83 to 106 in 1510866

	const resetIOUTypeIfChanged = useCallback(
	(newIOUType: IOURequestType) => {
	if (transaction?.iouRequestType === newIOUType) {
	return;
	}
	initMoneyRequest(reportID, policy, isFromGlobalCreate, transaction?.iouRequestType, newIOUType);
	},
	[policy, reportID, isFromGlobalCreate, transaction],
	);
	// Clear out the temporary expense if the reportID in the URL has changed from the transaction's reportID.
	useFocusEffect(
	useCallback(() => {
	// The test transaction can change the reportID of the transaction on the flow so we should prevent the reportID from being reverted again.
	if (
	(transaction?.reportID === reportID && iouType !== CONST.IOU.TYPE.CREATE && iouType !== CONST.IOU.TYPE.SUBMIT) ||
	isLoadingSelectedTab ||
	prevTransactionReportID !== transaction?.reportID
	) {
	return;
	}
	resetIOUTypeIfChanged(transactionRequestType);
	}, [transaction?.reportID, reportID, iouType, resetIOUTypeIfChanged, transactionRequestType, isLoadingSelectedTab, prevTransactionReportID]),
	);

First is from the tab navigator because per diem is not available, so it's triggered with the new tab, which is manual, so this one is correct.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 161 to 164 in 1510866

	<OnyxTabNavigator
	id={CONST.TAB.IOU_REQUEST_TYPE}
	defaultSelectedTab={CONST.TAB_REQUEST.SCAN}
	onTabSelected={resetIOUTypeIfChanged}

Second is from the useFocusEffect which initialize the iou type from transactionRequestType.

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 104 in 1510866

resetIOUTypeIfChanged(transactionRequestType);

Since it's a new flow, it will fallback to the selected tab, and in this case, it's per-diem. So, it's wrongly initialized with the wrong type.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 68 to 71 in 1510866

	const transactionRequestType = useMemo(
	() => ((transaction?.iouRequestType ?? shouldUseTab) ? selectedTab : CONST.IOU.REQUEST_TYPE.MANUAL),
	[transaction?.iouRequestType, shouldUseTab, selectedTab],
	);

What changes do you think we should make in order to solve the problem?

We need to check if per diem request is available, if not, then don't use the selected tab and instead fall back to default or undefined (using undefined works best after this PR is merged).

const transactionRequestType = useMemo(
    () => {
        if (transaction?.iouRequestType) {
            return transaction.iouRequestType;
        }

        if (shouldUseTab) {
            if (selectedTab === CONST.TAB_REQUEST.PER_DIEM && !shouldShowPerDiemOption) {
                return undefined;
            }
            return selectedTab;
        }

        return CONST.IOU.REQUEST_TYPE.MANUAL
    },
    [transaction?.iouRequestType, shouldUseTab, selectedTab, shouldShowPerDiemOption],
);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929972201414841468