[$250] Reports - Review button not shown for submitted & approved expense with category violation.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.54-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): slottwo1gcd1@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: User Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Create workspace with workflows enabled
3. Create a manual expense without selecting category
4. Submit and approve expense
5. Go to reports - approved

Expected Result:

Review button must be shown for submitted & approved expense with category violation.

Actual Result:

Review button not shown for submitted & approved expense with category violation.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929566369420925135
• Upwork Job ID: 1929566369420925135
• Last Price Increase: 2025-07-08

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Review button not shown for submitted & approved expense with category violation.

What is the root cause of that problem?

We are showing ActionCell in ExpenseItemHeaderNarrow Component only if the action is not equal to CONST.SEARCH.ACTION_TYPES.VIEW and CONST.SEARCH.ACTION_TYPES.REVIEW and in our case is action is equal to CONST.SEARCH.ACTION_TYPES.REVIEW that is why we don't see the review button.

App/src/components/SelectionList/Search/ExpenseItemHeaderNarrow.tsx

Lines 56 to 57 in 4510fc7

	const shouldShowAction = useMemo(() => action !== CONST.SEARCH.ACTION_TYPES.VIEW && action !== CONST.SEARCH.ACTION_TYPES.REVIEW, [action]);
	return (

App/src/components/SelectionList/Search/ExpenseItemHeaderNarrow.tsx

Lines 91 to 94 in 4510fc7

	{shouldShowAction && (
	<View>
	<ActionCell
	action={action}

What changes do you think we should make in order to solve the problem?

We need to change the calculation of shouldShowAction here to:

    const shouldShowAction = useMemo(() => action !== CONST.SEARCH.ACTION_TYPES.VIEW, [action]);

Also we need to remove the prop isLargeScreenWidth of ActionCell here to:

<ActionCell
                        action={action}
                        goToItem={onButtonPress}
                        isSelected={isSelected}
                        isLoading={isLoading}

Otherwise the ActionCell component returns null for review action if isLargeScreenWidth={false}:

App/src/components/SelectionList/Search/ActionCell.tsx

Lines 77 to 95 in 4510fc7

	if (action === CONST.SEARCH.ACTION_TYPES.VIEW || action === CONST.SEARCH.ACTION_TYPES.REVIEW || shouldUseViewAction || isChildListItem) {
	const buttonInnerStyles = isSelected ? styles.buttonDefaultSelected : {};
	return isLargeScreenWidth ? (
	<Button
	text={text}
	onPress={goToItem}
	small
	style={[styles.w100]}
	innerStyles={buttonInnerStyles}
	link={isChildListItem}
	shouldUseDefaultHover={!isChildListItem}
	icon={!isChildListItem && action === CONST.SEARCH.ACTION_TYPES.REVIEW ? Expensicons.DotIndicator : undefined}
	iconFill={theme.danger}
	iconHoverFill={theme.dangerHover}
	isNested
	/>
	) : null;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@lschurr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929566369420925135

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[kaushiktd]

Issue is not re-produce. Review button is already showing in android. You can check here.