[Due for payment 2025-06-19] [$250] "whats your name" screen on the onboarding modal repeated

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.54-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @blimpich
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Precondition: User (A) has a private domain on their email (B) validates their private domain to get access to existing workspaces and (C) skips the step to join existing workspaces

1. Go to temp-mail.org and get a temporary private domain email
2. Log into new dot with that email
3. Enter any name in the modal
4. Validate that email when asked in the onboarding modal
5. Press "skip" when asked to join specific workspaces

Expected Result:

We would complete/Continue the onboarding modal

Actual Result:

We return to the very first step in the modal

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2025-05-29.at.5.34.38.PM.mov

Recording.1279.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928274746261794531
• Upwork Job ID: 1928274746261794531
• Last Price Increase: 2025-05-30
• Automatic offers:
• suneox | Reviewer | 107563142
• nyomanjyotisa | Contributor | 107563144

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928274746261794531

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[nyomanjyotisa]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-30 02:47:00 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"whats your name" screen on the onboarding modal repeated

What is the root cause of that problem?

Both the private domain validation page and the workspaces page have incorrect skip button navigation logic. Both pages navigate to ROUTES.ONBOARDING_PURPOSE when skip is pressed, instead of properly handling the private domain flow completion

App/src/pages/OnboardingPrivateDomain/BaseOnboardingPrivateDomain.tsx

Line 100 in d6d25e6

onPress={() => Navigation.navigate(ROUTES.ONBOARDING_PURPOSE.getRoute(route.params?.backTo))}

App/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

Lines 152 to 154 in d6d25e6

	onPress={() => {
	Navigation.navigate(ROUTES.ONBOARDING_PURPOSE.getRoute(route.params?.backTo));
	}}

The issue is that when users with private domain emails skip joining workspaces, they need to have an onboardingPurposeSelected value set before the onboarding can be completed. However, the current flow sends them to the purpose selection page without any indication that they've already gone through the private domain flow, causing the flow to restart from the beginning

Additionally, even when users reach the purpose selection page, the BaseOnboardingPurpose component has an overly strict condition that prevents private domain users from completing onboarding directly. The original condition required both firstName AND lastName to be truthy:

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Line 88 in d6d25e6

if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName && personalDetailsForm?.lastName) {

What changes do you think we should make in order to solve the problem?

For private domain users who skip joining workspaces, we should set a default onboarding purpose (like CONST.ONBOARDING_CHOICES.LOOKING_AROUND) and then complete the onboarding flow directly, rather than sending them to the purpose selection screen

    const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});

    const isPrivateDomainAndHasAccessiblePolicies = !account?.isFromPublicDomain && !!account?.hasAccessibleDomainPolicies;

                        onPress={() => {
                            if (isPrivateDomainAndHasAccessiblePolicies && onboardingPersonalDetails?.firstName) {
                                setOnboardingPurposeSelected(CONST.ONBOARDING_CHOICES.LOOKING_AROUND);
                                completeOnboarding({
                                    engagementChoice: CONST.ONBOARDING_CHOICES.LOOKING_AROUND,
                                    onboardingMessage: CONST.ONBOARDING_MESSAGES[CONST.ONBOARDING_CHOICES.LOOKING_AROUND],
                                    firstName: onboardingPersonalDetails?.firstName ?? '',
                                    lastName: onboardingPersonalDetails?.lastName ?? '',
                                });
                                setOnboardingAdminsChatReportID();
                                setOnboardingPolicyID();

                                navigateAfterOnboarding(isSmallScreenWidth, canUseDefaultRooms);
                                return;
                            }
                            Navigation.navigate(ROUTES.ONBOARDING_PURPOSE.getRoute(route.params?.backTo));
                        }}

App/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

Line 152 in d6d25e6

onPress={() => {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Instead of completing onboarding immediately when users skip joining workspaces, we could allow them to proceed to the purpose selection page but skip the name input step for any purpose choice since they already entered their name during the private domain validation flow

The initial implementation required both firstName AND lastName to be present:

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Line 88 in d6d25e6

if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName && personalDetailsForm?.lastName) {

However, the lastName value can be an empty string (which is falsy), causing the condition to fail even when users had entered a firstName. We can update the condition to only require firstName, since lastName is optional in the onboarding flow

                if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName) {
                    completeOnboarding({
                        engagementChoice: choice,
                        onboardingMessage: CONST.ONBOARDING_MESSAGES[choice],
                        firstName: personalDetailsForm.firstName ?? '',
                        lastName: personalDetailsForm.lastName ?? '',
                        adminsChatReportID: onboardingAdminsChatReportID ?? undefined,
                        onboardingPolicyID,
                    });

Result

First Solution

New-Expensify.mp4

Alternative Solution

New-Expensify.mp4

[suneox]

@nyomanjyotisa Thanks for your proposal. However, it seems like this issue only occurs once per private domain on the latest main. Could you please investigate further to confirm this?