[Due for payment 2025-06-17] [$250] Remove totals from report action buttons

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.53-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Open an expense report submitted for approval
2. Observe the "Approve" button and the total displayed

Expected Result:

All report action buttons, including Submit, Approve, Pay, Review, etc. should not show report totals.

Actual Result:

Report action buttons should no longer have report totals in the button.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927995595051698113
• Upwork Job ID: 1927995595051698113
• Last Price Increase: 2025-05-29
• Automatic offers:
• brunovjk | Contributor | 107546168
• nyomanjyotisa | Contributor | 107550606

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-29 08:22:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Approve" button continues to display the total amount of the full report, including held expenses.

What is the root cause of that problem?

The amount is getting from getTotalAmountForIOUReportPreviewButton function.

App/src/components/MoneyReportHeader.tsx

Line 518 in 32cfed1

text={translate('iou.approve', getAmount(CONST.REPORT.PRIMARY_ACTIONS.APPROVE))}

App/src/components/MoneyReportHeader.tsx

Line 456 in 32cfed1

formattedAmount: getTotalAmountForIOUReportPreviewButton(moneyRequestReport, policy, actionType),

And we always return the total amount for approve action

App/src/libs/MoneyRequestReportUtils.ts

Line 127 in 32cfed1

return convertToDisplayString(totalDisplaySpend, report?.currency);

What changes do you think we should make in order to solve the problem?

We can remove the amount parameter from these places to remove the total from action buttons like Review, Submit, Approve, Pay, ...

App/src/components/MoneyReportHeader.tsx

Line 830 in 51404ce

text: translate('iou.settlePayment', {formattedAmount: totalAmount}),

App/src/components/MoneyReportHeader.tsx

Line 518 in 51404ce

text={translate('iou.approve', getAmount(CONST.REPORT.PRIMARY_ACTIONS.APPROVE))}

App/src/components/MoneyReportHeader.tsx

Line 677 in 51404ce

text: translate('iou.approve', getAmount(CONST.REPORT.SECONDARY_ACTIONS.APPROVE)),

For the Pay button, we need to add a flag to control the displayed amount because we still display the amount in the report preview action.

App/src/hooks/usePaymentOptions.ts

Line 159 in 51404ce

text: translate('iou.settlePersonal', {formattedAmount}),

App/src/hooks/usePaymentOptions.ts

Line 166 in 51404ce

text: translate('iou.payElsewhere', {formattedAmount: ''}),

App/src/hooks/usePaymentOptions.ts

Line 181 in 51404ce

text: translate('iou.settleBusiness', {formattedAmount}),

App/src/hooks/usePaymentOptions.ts

Line 193 in 51404ce

text: translate('iou.payElsewhere', {formattedAmount: ''}),

Optional: We can also do the same for pay action, or we can apply the same behavior of pay action for approve action

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Minor UI issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[JmillsExpensify]

For anyone submitting proposals, please note the updated OP. This is a simple case of Expensify wanting to remove totals from report action buttons.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021927995595051698113

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[thelullabyy]

For anyone submitting proposals, please note the updated OP. This is a simple case of Expensify wanting to remove totals from report action buttons.

@JmillsExpensify, that means we always want to remove the total from the button, even if there is no hold expense, right?

How about the report preview or secondary actions in the more button?