[Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Trip - After edited room name, tap "save" button return to setting instead of details

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.53-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6178121&group_by=cases:section_id&group_id=314227&group_order=asc
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: IOS 18.5, iphone promax 13
App Component: Other

Action Performed:

Precondition: user has booked a flight and a trip room was created

1. Launch app
2. User logged in
3. Navigate to trip room and edit the trip room name
4. Tap "SAVE" button

Expected Result:

User should return to the previous page, instead of navigating to Setting page

Actual Result:

User navigated to setting page after tapping Save button

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928097166391190147
• Upwork Job ID: 1928097166391190147
• Last Price Increase: 2025-05-29

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ryntgh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Trip - After edited room name, tap "save" button return to setting instead of details

What is the root cause of that problem?

The root cause is incorrect navigation logic in the TripChatNameEditPage component. After saving the trip room name, it navigates to the Settings page instead of returning to the previous page.

App/src/pages/TripChatNameEditPage.tsx

Line 62 in 8fc3e84

return Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.goBack(ROUTES.REPORT_SETTINGS.getRoute(reportID)));

The component is using ROUTES.REPORT_SETTINGS.getRoute(reportID) which takes the user to the Settings page, instead of ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID) which would return them to the report details page.

What changes do you think we should make in order to solve the problem?

Change the navigation route from ROUTES.REPORT_SETTINGS.getRoute(reportID) to ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID) to match the behavior of the GroupChatNameEditPage

return Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID)));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[garrettmknight]

Asking for help testing, but I'll open it up in the meantime.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928097166391190147

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User navigated to setting page after tapping Save button

What is the root cause of that problem?

This logic was added here. If we go to the PR, we can see it works well at this time.

App/src/pages/TripChatNameEditPage.tsx

Line 62 in bba5e0c

return Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.goBack(ROUTES.REPORT_SETTINGS.getRoute(reportID)));

The question is, why is this bug visible now?

It stems from how we're currently handling the goBack logic. In the past, goBack would only go to backToRoute if it was the first page in RHP, so it still works. However, the goBack logic was changed; now we always go back to the backToRoute if this param exists. And because the backToRoute is wrong here, we go to the wrong page after going back from the edit name page

App/src/libs/Navigation/Navigation.ts

Line 332 in bba5e0c

function goBack(backToRoute?: Route, options?: GoBackOptions) {

App/src/libs/Navigation/Navigation.ts

Line 281 in bba5e0c

function goUp(backToRoute: Route, options?: GoBackOptions) {

What changes do you think we should make in order to solve the problem?

Correct the backToRoute to the report detail page instead.

return Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID)));

App/src/pages/TripChatNameEditPage.tsx

Line 62 in bba5e0c

return Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.goBack(ROUTES.REPORT_SETTINGS.getRoute(reportID)));

)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, navigation issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.