[Due for payment 2025-06-18] [$250] Remove `Move expense` from the secondary action menu

[JmillsExpensify]

Problem

We recently added a Move expense option to the secondary action menu, but it shouldn't exist for two reasons:

• The design spec for New Expensify dictates that our members should use the Report row for this action with the expense thread.
• The design spec for New Expensify dictates that the Move expense option is strictly an option that appears in the bulk actions menu
  

Solution

Remove Move expense as a secondary action

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927661807363485913
• Upwork Job ID: 1927661807363485913
• Last Price Increase: 2025-05-28
• Automatic offers:
• nkdengineer | Contributor | 107576659

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021927661807363485913

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-29 00:26:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Move expense from the secondary action menu

What is the root cause of that problem?

changes request

What changes do you think we should make in order to solve the problem?

Remove it from here

App/src/components/MoneyReportHeader.tsx

Lines 769 to 782 in 4de0b0b

	[CONST.REPORT.SECONDARY_ACTIONS.MOVE_EXPENSE]: {
	text: translate('iou.moveExpenses', {count: 1}),
	icon: Expensicons.DocumentMerge,
	value: CONST.REPORT.SECONDARY_ACTIONS.MOVE_EXPENSE,
	onSelected: () => {
	if (!moneyRequestReport || !transaction) {
	return;
	}
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_REPORT.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction.transactionID, moneyRequestReport.reportID, getReportRHPActiveRoute()),
	);
	},
	},

App/src/CONST.ts

Line 1227 in 143c605

MOVE_EXPENSE: 'moveExpense',

And here

App/src/libs/ReportSecondaryActionUtils.ts

Lines 485 to 487 in 4de0b0b

	if (isMoveTransactionAction(reportTransactions, reportActions)) {
	options.push(CONST.REPORT.SECONDARY_ACTIONS.MOVE_EXPENSE);
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[github-actions]

⚠️ @nyomanjyotisa Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-28 12:39:53 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Move expense from the secondary action menu

What is the root cause of that problem?

We define move expense in secondary action here

App/src/components/MoneyReportHeader.tsx

Lines 769 to 782 in 4de0b0b

	[CONST.REPORT.SECONDARY_ACTIONS.MOVE_EXPENSE]: {
	text: translate('iou.moveExpenses', {count: 1}),
	icon: Expensicons.DocumentMerge,
	value: CONST.REPORT.SECONDARY_ACTIONS.MOVE_EXPENSE,
	onSelected: () => {
	if (!moneyRequestReport || !transaction) {
	return;
	}
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_REPORT.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction.transactionID, moneyRequestReport.reportID, getReportRHPActiveRoute()),
	);
	},
	},

What changes do you think we should make in order to solve the problem?

1. We should remove it

2. We also need to remove some useless code

App/src/libs/ReportSecondaryActionUtils.ts

Lines 485 to 487 in 4de0b0b

	if (isMoveTransactionAction(reportTransactions, reportActions)) {
	options.push(CONST.REPORT.SECONDARY_ACTIONS.MOVE_EXPENSE);
	}

App/src/CONST.ts

Line 1228 in 4de0b0b

MOVE_EXPENSE: 'moveExpense',

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[c3024]

@JmillsExpensify

We are removing "Move action" secondary action completely from the repo, right?