[Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Expense - Download as csv in offline via more options & details page is inconsistent

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.53-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): slottwo1newiop@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Other

Action Performed:

1. Launch app
2. Open a workspace chat
3. Create a manual expense
4. Open the expense
5. Turn off internet
6. Tap more - download as csv
7. Tap header - download as csv

Expected Result:

Download as csv in offline via more options and details page must show same behaviour.

Actual Result:

Download as csv in offline shown 2 different behaviour. Download via details page shown you appear offline, and via more options displays download failed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929568331994050524
• Upwork Job ID: 1929568331994050524
• Last Price Increase: 2025-06-02
• Automatic offers:
• nkdengineer | Contributor | 107539658

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Download as csv in offline shown 2 different behaviour. Download via details page shown you appear offline, and via more options displays download failed.

What is the root cause of that problem?

We don't have OfflineModal in MoneyRequestHeader

App/src/pages/ReportDetailsPage.tsx

Lines 541 to 551 in 352de72

	action: () => {
	if (isOffline) {
	setOfflineModalVisible(true);
	return;
	}
	exportReportToCSV({reportID: report.reportID, transactionIDList}, () => {
	setDownloadErrorModalVisible(true);
	});
	},
	});

App/src/components/MoneyReportHeader.tsx

Lines 645 to 653 in 352de72

	onSelected: () => {
	if (!moneyRequestReport) {
	return;
	}
	exportReportToCSV({reportID: moneyRequestReport.reportID, transactionIDList: transactionIDs}, () => {
	setDownloadErrorModalVisible(true);
	});
	},
	},

What changes do you think we should make in order to solve the problem?

We should add this modal in MoneyRequestHeader and make it consistent with ReportDetailsPage

         <DecisionModal
                    title={translate('common.youAppearToBeOffline')}
                    prompt={translate('common.offlinePrompt')}
                    isSmallScreenWidth={isSmallScreenWidth}
                    onSecondOptionSubmit={() => setOfflineModalVisible(false)}
                    secondOptionText={translate('common.buttonConfirm')}
                    isVisible={offlineModalVisible}
                    onClose={() => setOfflineModalVisible(false)}
                />

          onSelected: () => {
                if (!moneyRequestReport) {
                    return;
                }
                if(isOffline){
                    setOfflineModalVisible(true);
                    return;
                }
                exportReportToCSV({reportID: moneyRequestReport.reportID, transactionIDList: transactionIDs}, () => {
                    setDownloadErrorModalVisible(true);
                });
            },

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Or we should not show the download option in more options if we are offline, we should pass isOffline param to getSecondaryReportActions function or get this from isOffline in NetworkStore.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 477 to 479 in 352de72

	options.push(CONST.REPORT.SECONDARY_ACTIONS.DOWNLOAD_CSV);
	options.push(CONST.REPORT.SECONDARY_ACTIONS.DOWNLOAD_PDF);

Or we can remove offline modal in ReportDetailsPage

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@isabelastisser Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929568331994050524

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)