[Due for payment 2025-06-17] [$250] App crashes when accessing the transition URL without a token in the URL.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.49-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Open App and log in with a user.
2. Try to access: staging.new.expensify.com/transition?

Expected Result:

A logged-in user should not see a crash here. Instead, they should be redirected to the Your session has expired. Please sign in again. page, similar to what non-logged-in users see.

Actual Result:

The app crashes when accessing the transition page without a token in the URL.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

transition-crash.mov

Recording.1266.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928016971429622839
• Upwork Job ID: 1928016971429622839
• Last Price Increase: 2025-05-29

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

Proposal by @jayeshmangwani

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when accessing the transition URL without passing token in the URL.

What is the root cause of that problem?

When a logged-in user accesses the transition URL, it navigates to LogOutPreviousUserPage.

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 568 to 571 in 6871ba9

	<RootStack.Screen
	name={SCREENS.TRANSITION_BETWEEN_APPS}
	options={defaultScreenOptions}
	getComponent={loadLogOutPreviousUserPage}

In this page, we're trying to access route.params.authTokenType, but since params is null, this causes a crash.

App/src/pages/LogOutPreviousUserPage.tsx

Line 33 in 6871ba9

const isSupportalLogin = route.params.authTokenType === CONST.AUTH_TOKEN_TYPES.SUPPORT;

What changes do you think we should make in order to solve the problem?

We should use optional chaining when accessing route.params, similar to how it's handled in src/pages/LogInWithShortLivedAuthTokenPage.tsx.

Instead of directly accessing the parameters, we can safely destructure them like this:

const {
    authTokenType,
    shortLivedAuthToken,
    exitTo,
} = route?.params ?? {};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Its UI bug, not necessary

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jliexpensify]

Querying what the transition URL is.

[melvin-bot]

@jliexpensify Huh... This is 4 days overdue. Who can take care of this?

[jliexpensify]

Waiting on @mjasikowski to repsond here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928016971429622839