Skip to content

[$250] Reports - After moving expense and deleting all expenses, table header remains in blank page #62507

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.48-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #62270
Email or phone of affected tester (no customers): sjdiodjsodsj232@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create two workspace chats.
  3. Submit one expense to each workspace chat.
  4. Go to Reports.
  5. Go to Expense Reports.
  6. Select one of the expenses via checkbox.
  7. Click dropdown button.
  8. Click Move expense.
  9. Select the unselected report.
  10. Select all expenses via checkbox.
  11. Click dropdown button > Delete.
  12. Delete the expenses.

Expected Result:

Table header will disappear.
Empty state will show up.

Actual Result:

Table header does not disappear.
Empty state does not show up.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6838556_1747855043695.20250522_030739.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925294263743135596
  • Upwork Job ID: 1925294263743135596
  • Last Price Increase: 2025-05-21
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 21, 2025
  2. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 21, 2025

    @melvin-bot

    Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 21, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 21, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nlemma commented on May 21, 2025

    @nlemma
    Author

    @bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. nabi-ebrahimi commented on May 21, 2025

    @nabi-ebrahimi
    Contributor

    Can see the move expense option btw.

  8. 11 remaining items

  9. nkdengineer commented on May 26, 2025

    @nkdengineer
    Contributor

    @alitoshmatov what do you think about my proposal here?

  10. alitoshmatov commented on May 27, 2025

    @alitoshmatov
    Contributor

    @nkdengineer Thank you for your proposal. Your RCA is correct and solution works. I think we should check reports for empty transactions.

    We can go with @nkdengineer 's proposal

    C+ reviewed 🎀 👀 🎀

  11. melvin-bot commented on May 27, 2025

    @melvin-bot

    Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

  12. puneetlath commented on May 27, 2025

    @puneetlath
    Contributor

    Hmm, interesting. So if you're in the beta everything works correctly. I'm not sure this is worth doing anything about then, since it'll naturally fix itself shortly when the beta becomes live. What do you think @bfitzexpensify?

  13. nkdengineer commented on May 27, 2025

    @nkdengineer
    Contributor

    I think even though the issue will resolve itself when the beta goes live, we should still consider fixing it now because this bug creates a poor experience for non-beta users right now

  14. bfitzexpensify commented on May 28, 2025

    @bfitzexpensify
    Contributor

    I agree we can just wait for that beta to go live - this is a niche flow, and only a display issue, not something that prevents a user taking an action.

  15. nkdengineer commented on May 29, 2025

    @nkdengineer
    Contributor

    @puneetlath @bfitzexpensify I received a C+ review here, and my proposal addresses the bug mentioned in the original post. Since the issue has been marked as external, is there any chance I could be considered for partial compensation for my contribution?

  16. nkdengineer commented on Jun 2, 2025

    @nkdengineer
    Contributor

    @puneetlath @bfitzexpensify could you please check my comment here?

  17. bfitzexpensify commented on Jun 2, 2025

    @bfitzexpensify
    Contributor

    @nkdengineer this would be eligible for partial payment if you as the contributor were hired - in this case, though your proposal was selected by the C, we didn't proceed with hiring.

  18. nkdengineer commented on Jun 2, 2025

    @nkdengineer
    Contributor

    Thanks for the reply @bfitzexpensify. I think we still provide payment to the contributor if the proposal is C+ reviewed, we have a similar case as in this issue

    50% payment if the contributor wasn't assigned and
    The proposal was 🎀👀🎀 by the C+, and
    Most of the code used in the fix came from the accepted proposal

    Quote from here

  19. bfitzexpensify commented on Jun 2, 2025

    @bfitzexpensify
    Contributor

    This case doesn't satisfy the last requirement:

    Most of the code used in the fix came from the accepted proposal

    In your proposal, you noted that:

    Note: If you turn on beta, you will see the report with no expense.

    And as we're not doing anything for non-beta users, this means the resolution for this already existed pre-proposal.

  20. nkdengineer commented on Jun 3, 2025

    @nkdengineer
    Contributor

    That makes sense, thanks @bfitzexpensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions