[Due for payment 2025-06-16] [$250] Android&iOS - Chat - Tapping migrated user welcome link navigates to reports page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.47-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: (#61886)
Email or phone of affected tester (no customers): Applause ws17 search
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: User Settings

Action Performed:

1. Launch app
2. Open a chat
3. Send a message - https://staging.new.expensify.com/onboarding/migrated-user-welcome
4. Tap on the link

Note : when opening link from browser, migrated modal shown but from opening chat directs to reports page. Pr : #61886

Expected Result:

Tapping on migrated user welcome link musnt navigate to reports page.

Actual Result:

Tapping on migrated user welcome link navigates to reports page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6837852_1747807504000.Screenrecorder-2025-05-21-11-32-30-981.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021925316908768913249
• Upwork Job ID: 1925316908768913249
• Last Price Increase: 2025-05-28
• Automatic offers:
• thelullabyy | Contributor | 107534127

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Tapping on the migrated user welcome link currently navigates the user to the Reports page instead of keeping them on the intended welcome screen.

What is the root cause of that problem?

• When the migrated user welcome link is tapped, it opens the MigratedUserWelcomeModal.
• Inside this modal, due to the condition at line 66 not being met, the fallback logic at lines 69–71 is executed, which navigates the user to the Reports page.

What changes do you think we should make in order to solve the problem?

1. Update the route definition in ROUTES.ts to accept an optional shouldOpenSearch parameter:

    MIGRATED_USER_WELCOME_MODAL: {
        route: 'onboarding/migrated-user-welcome',
        getRoute: (shouldOpenSearch?: boolean) => getUrlWithBackToParam(
            `onboarding/migrated-user-welcome?${shouldOpenSearch ? 'shouldOpenSearch=true' : ''}`,
            undefined,
            false
        ),
    },

2. In NavigationRoot.tsx, stop passing true to the getRoute() function:

    Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute());

3. Instead, pass true when navigating from useOnboardingFlow.ts:

    Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute(true));

4. In MigratedUserWelcomeModal.tsx, update the isFromRoot variable to reflect shouldOpenSearch:

    const shouldOpenSearch = route?.params?.shouldOpenSearch === 'true';

5. Update the condition at line 66 to use !shouldOpenSearch:

    if (!!(hasBeenAddedToNudgeMigration && !dismissedProductTraining?.migratedUserWelcomeModal) || !shouldOpenSearch) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021925316908768913249

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[huult]

Assign me because I am the owner of the PR

[thelullabyy]

@arosiclair This issue isn’t caused by that PR, and the problem that PR was trying to solve is different from what's described here.

Also, since this issue is labeled as external, I think we can treat it like any other external issue that contributors are free to work on.

[thelullabyy]

@fedirjh When you have a moment, could you please review my proposal?