[Due for payment 2025-06-24] [$125] [One regression] [AU] - Workspace - Search Bar is missing on Workspace Page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.47-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2950454

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log with an any account
3. Go to Workspaces
4. Create 8 workspaces and name each one different
5. Click on the workspace selector
6. Verify a search bar is displayed

Expected Result:

Search bar is displayed.
The workspace selector should display a search bar whenever there are 8 or more workspaces.

Actual Result:

Search bar is not displayed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927382486119472485
• Upwork Job ID: 1927382486119472485
• Last Price Increase: 2025-06-17
• Automatic offers:
• daledah | Contributor | 107551057

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search bar is not displayed, it's a new feature

What is the root cause of that problem?

Currently we don't implement searching functionality for Workspace list page

What changes do you think we should make in order to solve the problem?

We should add SearchBar usage to Workspace list page.

First, create variables and logics to calculate search result

    const [inputValue, setInputValue] = useState<string>('');
    const [filteredWorkspaces, setFilteredWorkspaces] = useState<WorkspaceItem[]>(workspaces);

    useEffect(() => {
        const normalizedSearchQuery = inputValue.trim().toLowerCase();
        const filtered = normalizedSearchQuery.length ? workspaces.filter((item) => item.title.toLowerCase().includes(normalizedSearchQuery)) : workspaces;
        setFilteredWorkspaces(filtered);
    }, [inputValue, workspaces]);

Since we don't sort workspaces, there's no need to use useSearchResult. But we can implement its usage like below if preferred

const filterWorkspace = useCallback((workspace, inputValue) => workspace.title.toLowerCase().includes(inputValue), [])
const sortWorkspace = useCallback(workspaces => workspaces, [])
const [inputValue, setInputValue, filteredWorkspaces] = useSearchResult(workspaces, filterWorkspace, sortWorkspace)

Add SearchBar above here

App/src/pages/workspace/WorkspacesListPage.tsx

Line 559 in 02e9906

<FlatList

{workspaces.length >= 8 && (
         <SearchBar
                 label="Find workspace"
                 inputValue={inputValue}
                 onChangeText={setInputValue}
                 shouldShowEmptyState={filteredWorkspaces.length === 0}
         />
)}

Optional, we should make the search bar appearance threshold as 15 instead of 8 for consistency

Update here to hide header when there's no result found

App/src/pages/workspace/WorkspacesListPage.tsx

Line 562 in 02e9906

ListHeaderComponent={listHeaderComponent}

ListHeaderComponent={filteredWorkspaces.length > 0 && listHeaderComponent}

Here's the result, search bar styles and paddings can be discussed later in PR phase

Screen.Recording.2025-05-20.at.23.02.15.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, UI Issue and new feature

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[sakluger]

The regression test is related to the "Workspace Switcher", not the Workspaces settings page. I'm checking in Slack if we still have this workspace switcher feature in the latest version of New Expensify.

[sakluger]

The workspace switcher was deprecated with the Left Hand Bar, so that regression test is out of date. We are still completing the resource updates, so the regression test should end up getting removed soon.

[sakluger]

Reopening just in case we want to do this.

[trjExpensify]

Optional, we should make the search bar appearance threshold as 15 instead of 8 for consistency

Yeah, 15 is the number for this SearchBar introduced here, so we should use that: #59864

[trjExpensify]

Also for consistency with the others (i.e "Find category", "Find member" etc) the search bar text should be "Find workspace" not "Search workspace".

[dubielzyk-expensify]

A mock in case it's useful. cc @Expensify/design

[shawnborton]

Looks great to me!

[dubielzyk-expensify]

Would be great if we can also add the search bar to Workspaces -> Taxes as well 😄