Skip to content

[Due for payment 2025-05-30] [Desktop Navigation] Save the last visited path for the Accounts pages #62320

Closed

Description

@mountiny

Desktop navigation follow up

Similar to this issue #56806, which focused on the settings tab - after splitting the workspaces and Account settings to two tabs, we need to refactor the logic and keep the last visited path in the Workspace settings as well as Account settings navigator

Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 19, 2025
  2. melvin-bot commented on May 19, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. changed the title [-]Save the last visited path for the Accounts pages[/-] [+][Desktop Navigation] Save the last visited path for the Accounts pages[/+] on May 21, 2025
  4. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 23, 2025
  5. changed the title [-][Desktop Navigation] Save the last visited path for the Accounts pages[/-] [+][Due for payment 2025-05-30] [Desktop Navigation] Save the last visited path for the Accounts pages[/+] on May 23, 2025
  6. melvin-bot commented on May 23, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on May 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @borys3kk does not require payment (Contractor)
    • @dukenv0307 requires payment through NewDot Manual Requests
  8. melvin-bot commented on May 23, 2025

    @melvin-bot

    @dukenv0307 @isabelastisser @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. dukenv0307 commented on May 26, 2025

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    Testcase 1:

    1. On wide screen go to accounts tab
    2. Select a tab there, for example preferences
    3. Go to any other tab, for example inbox
    4. Refresh site
    5. Go to accounts tab
    6. You should have been redirected to preferences

    Testcase 2:

    1. On wide screen go to accounts tab
    2. Select a tab there, for example about
    3. Go to any other tab
    4. Refresh site
    5. Resize window to narrow layout
    6. Go to accounts tab
    7. You should be on main settings screen

    Do we agree 👍 or 👎

  10. mountiny commented on May 26, 2025

    @mountiny
    ContributorAuthor

    Payments handled as part of the project so no need to pay here

    @isabelastisser could you please help us with adding the new test rail cases? thanks!

  11. isabelastisser commented on May 28, 2025

    @isabelastisser
    Contributor

    All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions