[Due for payment 2025-07-17] [$250] Report - No Submit option for a duplicate expenses

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.46-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6115956
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Chat Report View

Action Performed:

Preconditions:
On an Expensifail account that is an admin of a workspace and has the following setup:

Delayed Submissions is enabled and set to manual
Approvals are Enabled
An employee has been invited to the policy (tester must have access to the account)
Employee - Steps:

1. Log in as the employee of the workspace
2. Navigate to the workspace chat
3. Submit 2 duplicate expenses to the workspace
4. Verify that the report preview displays a "Review" button
5. Navigate to the report details
6. Verify that a button to "Review Duplicates" is displayed in the report header, along with a "More" button
7. Verify that the More button contains Download, Change workspace, Delete, and View details
8. Do not fix the duplicate expenses
9. Submit the expense report to the approver

Expected Result:

The More button should display a Submit option to submit the duplicate expenses to the Approver

Actual Result:

No submit option in the More button on the Employee account

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021925955260191535157
• Upwork Job ID: 1925955260191535157
• Last Price Increase: 2025-06-13
• Automatic offers:
• nkdengineer | Contributor | 107793118

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No submit option in the More button on the Employee account

What is the root cause of that problem?

For employees (submitter), the submit-secondary action is only shown if the schedule submitted is enabled. In this case, the manual submit is enabled then this option isn't shown as a secondary action.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 89 to 91 in c4d89f0

	const isScheduledSubmitEnabled = policy?.harvesting?.enabled && autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL;
	return !!isScheduledSubmitEnabled;

For the primary action, the review duplicate action has higher priority than the submit action

App/src/libs/ReportPrimaryActionUtils.ts

Lines 265 to 299 in c4d89f0

	function getReportPrimaryAction(
	report: Report,
	reportTransactions: Transaction[],
	violations: OnyxCollection<TransactionViolation[]>,
	policy?: Policy,
	reportNameValuePairs?: ReportNameValuePairs,
	reportActions?: ReportAction[],
	): ValueOf<typeof CONST.REPORT.PRIMARY_ACTIONS> | '' {
	const isPayActionWithAllExpensesHeld = isPayAction(report, policy, reportNameValuePairs) && hasOnlyHeldExpenses(report?.reportID);
	if (isAddExpenseAction(report, reportTransactions)) {
	return CONST.REPORT.PRIMARY_ACTIONS.ADD_EXPENSE;
	}
	if (isMarkAsCashAction(report, reportTransactions, violations, policy)) {
	return CONST.REPORT.PRIMARY_ACTIONS.MARK_AS_CASH;
	}
	if (isReviewDuplicatesAction(report, reportTransactions, policy)) {
	return CONST.REPORT.PRIMARY_ACTIONS.REVIEW_DUPLICATES;
	}
	if (isRemoveHoldAction(report, reportTransactions) || isPayActionWithAllExpensesHeld) {
	return CONST.REPORT.PRIMARY_ACTIONS.REMOVE_HOLD;
	}
	if (isSubmitAction(report, reportTransactions, policy, reportNameValuePairs)) {
	return CONST.REPORT.PRIMARY_ACTIONS.SUBMIT;
	}
	if (isApproveAction(report, reportTransactions, policy)) {
	return CONST.REPORT.PRIMARY_ACTIONS.APPROVE;
	}
	if (isPayAction(report, policy, reportNameValuePairs)) {

What changes do you think we should make in order to solve the problem?

We can get the primary action here and pass it to isSubmitAction

const primaryAction = getReportPrimaryAction({
      report,
      chatReport,
      reportTransactions,
      violations,
      policy,
      reportNameValuePairs,
      reportActions,
      isChatReportArchived,
  });
if (isSubmitAction(report, reportTransactions, policy, reportNameValuePairs, primaryAction)) {
    options.push(CONST.REPORT.SECONDARY_ACTIONS.SUBMIT);
}

App/src/libs/ReportSecondaryActionUtils.ts

Line 387 in c4d89f0

function getSecondaryReportActions(

Then we can check here to return true for the submitter if the primary action is not submit action.

return !!isScheduledSubmitEnabled || primaryAction !== CONST.REPORT.PRIMARY_ACTIONS.SUBMIT;

App/src/libs/ReportSecondaryActionUtils.ts

Lines 89 to 91 in c4d89f0

	const isScheduledSubmitEnabled = policy?.harvesting?.enabled && autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL;
	return !!isScheduledSubmitEnabled;

OPTIONAL: We can also filter out the secondary action if it's already in the primary action.

We can check for other actions that exist from both primary and secondary action if it has the same problem.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update getSecondaryReportActions test and verify the submit action is on the list for this case.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021925955260191535157

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[jayeshmangwani]

I'm not sure if this issue is a bug or the expected behavior. If there's a duplicate report, the first user should see the Review duplicates button, and only after the duplicate is resolved should the Submit button be shown.
So @abekkala, before moving forward, can we please double-check whether this change is actually needed, or if the current behavior is already correct?