Company Cards - The list of banks is not displayed when adding a company card

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.1.46-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Expensifail account
Issue reported by: Applause Internal Team
Device used: Mac 15.4.1/Safari, Desktop, iPhone 13 iOS 18.4.1/Safari, Hybrid
App Component: Workspace Settings

Action Performed:

Navigate to https://staging.new.expensify.com
Log in with expensifail account
Navigate to Company Cards on workspace settings
Click on Add Company Cards
Select United States

Expected Result:

The "Who’s your bank?" page with a list of banks is displayed after clicking the Add cards button

Actual Result:

When trying to add a company card, the "Where's your bank located?" page is opened, after selecting a country, there is no list of bank.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6833756_1747443052044.Recording__74.mp4

View all open jobs on GitHub

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MariaHCD

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@CortneyOfstad

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When adding a company card, after selecting the country and choosing the "Direct feed" connection type, the user is immediately redirected to the "Check your browser window" page. Instead, the user should see the "Who’s your bank?" page with a list of banks to choose from.

What is the root cause of that problem?

In the file
src/pages/workspace/companyCards/addNew/SelectFeedType.tsx
after selecting "Direct feed", the flow transitions directly to the BANK_CONNECTION step, skipping the SELECT_BANK step.
As a result, the component responsible for displaying the list of banks (SelectBankStep) is never shown, and the user cannot manually select their bank.

Problematic code snippet:

setAddNewCompanyCardStepAndData({
    step: typeSelected === CONST.COMPANY_CARDS.FEED_TYPE.DIRECT ? CONST.COMPANY_CARDS.STEP.BANK_CONNECTION : CONST.COMPANY_CARDS.STEP.CARD_TYPE,
    data: {selectedFeedType: typeSelected},
});

What changes do you think we should make in order to solve the problem?

In SelectFeedType.tsx, update the flow so that after selecting "Direct feed", the next step is SELECT_BANK instead of BANK_CONNECTION.

setAddNewCompanyCardStepAndData({
               step: typeSelected === CONST.COMPANY_CARDS.FEED_TYPE.DIRECT ? CONST.COMPANY_CARDS.STEP.SELECT_BANK : CONST.COMPANY_CARDS.STEP.CARD_TYPE,
    data: {selectedFeedType: typeSelected},
});

This will ensure the user is first shown the list of banks to choose from, and only after selecting a bank will the bank connection window open.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

User selects a country, then "Direct feed" — the "Who’s your bank?" page with a list of banks should appear.
After selecting a bank, only then should the bank connection window open.
Ensure the flow for other feed types (e.g., "Commercial feed") is not broken.
Test that navigating back and changing the country or feed type does not break the flow.
Verify the fix works on both mobile and desktop versions.

What alternative solutions did you explore? (Optional)

N/A

Demo

The video below demonstrates the bug fix in action.

Result.mp4

Not a deploy blocker - this feature is under beta and is currently a work in progress.

Without the beta, the navigation works correctly: https://expensify.slack.com/archives/C01GTK53T8Q/p1747642477414949?thread_ts=1747470921.807749&cid=C01GTK53T8Q

The correct navigation will be implemented here: #62117

Navigation Menu

Repository navigation

Company Cards - The list of banks is not displayed when adding a company card #62246

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Company Cards - The list of banks is not displayed when adding a company card #62246

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 17, 2025

melvin-bot commented on May 17, 2025

melvin-bot commented on May 17, 2025

github-actions commented on May 17, 2025

nlemma commented on May 17, 2025

ganzz4 commented on May 18, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

ganzz4 commented on May 18, 2025

MariaHCD commented on May 19, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions