Repository navigation
[Due for payment 2025-05-30] [Report Creation UI] [$125] Incorrect border color on workspace avatar in report headers on Reports > Expense Reports #62115
Description
Activity
Current assignee @shawnborton is eligible for the Design assigner, not assigning anyone new.
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
- changed the title
[-]Incorrect border color on workspace avatar in report headers on Reports > Expense Reports[/-][+][$250] Incorrect border color on workspace avatar in report headers on Reports > Expense Reports[/+]on May 15, 2025 Job added to Upwork: https://www.upwork.com/jobs/~021923040904351845822
43 remaining items
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-30. 🎊
For reference, here are some details about the assignees on this issue:
- @dukenv0307 requires payment through NewDot Manual Requests
- @mkzie2 requires payment automatic offer (Contributor)
@dukenv0307 @trjExpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
BugZero Checklist:
- [Contributor] Classify the bug:
Bug classification
Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production
- 2b. Reported on staging (deploy blocker)
- 2c. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/42410/files#r2106805063
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template -
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
- Submit two expenses to a workspace
- Go to Reports > Expense Reports
- Verify the subscript workspace avatar in the report row header has the same background with the row
- Hover over the report row, verify the subscript workspace avatar in the report row header has the same background with the row
- Press the checkbox in the report row header (or long press the report row > Select > press checkbox), verify the subscript workspace avatar in the report row header has the same background with the row
Do we agree 👍 or 👎
All good on the regression test front, we're adding them centrally. Payment summary as follows:
- $125 to @mkzie2 for the PR (Please accept the offer)
- $125 to @dukenv0307 for the C+ review (Go ahead and request)
Not overdue
@trjExpensify I accepted, tysm!
(The offer price is incorrect at $50 though, I assume the correct amount $125 will be paid out)
Yep, amended on acceptance. Paid, closing!
- moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrate
on Jun 2, 2025 $125 approved for @dukenv0307
Metadata
Metadata
Labels
Type
Projects
- Status
We recently updated the header style on expense reports in the Reports > Expense Reports view. However, the workspace avatar uses an incorrect border color. Notice that it doensn't match the background:
And the same thing happens when you select the report:
cc @trjExpensify @mountiny @Kicu @sumo-slonik
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @trjExpensify