Repository navigation
Reports - Selected saved search is not highlighted #61974
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.45-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+300402kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Search
Action Performed:
Precondition:
- Have some saved searches
- Launch Expensify app.
- Go to Reports.
- Tap bookmark icon.
- Tap on the saved search.
- Tap bookmark icon.
Expected Result:
The selected saved search will be highlighted.
Actual Result:
The selected saved search is not highlighted.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon May 14, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 14, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon May 14, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon May 14, 2025
💬 A slack conversation has been started in #expensify-open-source
thelullabyy commentedon May 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The selected saved search is not highlighted.
What is the root cause of that problem?
We define which item is focused here
App/src/hooks/useSearchTypeMenu.tsx
Line 146 in d814c8f
but have not passed this property into the list
What changes do you think we should make in order to solve the problem?
Add
...baseMenuItemin this to pass property isFocused to item listApp/src/hooks/useSearchTypeMenu.tsx
Lines 149 to 150 in d814c8f
The similar logic is implemented here
App/src/pages/Search/SearchTypeMenu.tsx
Lines 89 to 90 in d814c8f
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
thelullabyy commentedon May 14, 2025
Willing to open PR early if this is an urgent case
2 remaining items
mountiny commentedon May 14, 2025
@martasudol @OlimpiaZurek is this from one of the perf refactors? Can you please take a look
OlimpiaZurek commentedon May 14, 2025
@mountiny looks like this is coming from my PR: #60959
OlimpiaZurek commentedon May 14, 2025
Found the root cause, preparing a PR with the fix
OlimpiaZurek commentedon May 14, 2025
I had prepared a PR with the fix, but since the offending PR was reverted, I’ll raise a new one with the changes and fix again
melvin-bot commentedon Jun 9, 2025
This issue has not been updated in over 15 days. @robertjchen, @OlimpiaZurek, @bfitzexpensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
robertjchen commentedon Jun 9, 2025
It looks like this was resolved? Please re-open if not the case 👍