[Due for payment 2025-05-27] [$125] [Report Creation UI] Not here page opens after clicking Amount in expense thread RHP

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.45-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sn98s9d@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• Have some expenses that can be edited.

1. Go to staging.new.expensify.com
2. Go to Reports.
3. Click on any expense.
4. Click Amount.

Expected Result:

Amount editor will open.

Actual Result:

Not here page opens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021922456063827471643
• Upwork Job ID: 1922456063827471643
• Last Price Increase: 2025-05-14
• Automatic offers:
• jaydamani | Contributor | 107296060

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[jaydamani]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-13 20:31:43 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page opens after clicking Amount in expense thread RHP

What is the root cause of that problem?

In this PR, a new param backToReport was added to MONEY_REQUEST_STEP_AMOUNT.getRoute but this new param was not added in below call so the backTo gets passed as backToReport which creates a broken url

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 610 in 1af42e2

ROUTES.MONEY_REQUEST_STEP_AMOUNT.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction.transactionID, report.reportID, '', getReportRHPActiveRoute()),

What changes do you think we should make in order to solve the problem?

Upate below function call and pass blank string for backToReport

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 610 in 1af42e2

ROUTES.MONEY_REQUEST_STEP_AMOUNT.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction.transactionID, report.reportID, '', getReportRHPActiveRoute()),

we should here as well

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 370 in 1af42e2

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_AMOUNT.getRoute(action, iouType, transactionID, reportID, CONST.IOU.PAGE_INDEX.CONFIRM, Navigation.getActiveRoute()));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

no test needed

What alternative solutions did you explore? (Optional)

Remove the parameter as it is not being used anywhere.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.