[Due for payment 2025-06-27] [$250] The RHN modal is dismissed after clicking incomplete button in task

@dukenv0307

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.44-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Go to Reports page
Go to Tasks page
Click on completed task
Note that RHN modal is still displayed
On RHN, click on task title > Mark as incomplete button

Expected Result:

The RHN modal is still displayed

Actual Result:

The RHN modal is dismissed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

bug.mov

Recording.1220.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021922282923967120988
Upwork Job ID: 1922282923967120988
Last Price Increase: 2025-05-20

Issue Owner

Current Issue Owner: @maddylewis

@maddylewis

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dukenv0307

Proposal by @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

The RHN modal is dismissed

What is the root cause of that problem?

We dismiss the modal after marking as incompleted. It leads all RHP modals are closed.

App/src/pages/ReportDetailsPage.tsx

Lines 545 to 548 in 12e6cb3

    
           action: callFunctionIfActionIsAllowed(() => { 
        
               Navigation.dismissModal(); 
        
               reopenTask(report); 
        
           }),

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack(backTo); like the way we did with unapprove action here

         action: callFunctionIfActionIsAllowed(() => {
              Navigation.goBack(backTo);
              reopenTask(report);
          }),

App/src/pages/ReportDetailsPage.tsx

Lines 545 to 548 in 12e6cb3

    
           action: callFunctionIfActionIsAllowed(() => { 
        
               Navigation.dismissModal(); 
        
               reopenTask(report); 
        
           }),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, Navigation issue

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021922282923967120988

@abdulrahuman5196

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The RHN modal is getting closed after clicking on the "Mark as incomplete" button.

What is the root cause of that problem?

The problem is in action function in which we call navigator class function to close the modal.

App/src/pages/ReportDetailsPage.tsx

Lines 513 to 522 in e7f78df

    
           items.push({ 
        
               key: CONST.REPORT_DETAILS_MENU_ITEM.MARK_AS_INCOMPLETE, 
        
               icon: Expensicons.Checkmark, 
        
               translationKey: 'task.markAsIncomplete', 
        
               isAnonymousAction: false, 
        
               action: callFunctionIfActionIsAllowed(() => { 
        
                   Navigation.dismissModal(); 
        
                   reopenTask(report); 
        
               }), 
        
           });

What changes do you think we should make in order to solve the problem?

Instead of calling dismissed function we should call the route back.

const backPath=router.params.path

Navigation.backTo(backPath);

reopenTask(report);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Nope

What alternative solutions did you explore? (Optional)

I'm not sure but opening the detail screen could be a better alternative.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@abdulrahuman5196

@abdulrahuman5196 Huh... This is 4 days overdue. Who can take care of this?

@abdulrahuman5196

Payment Summary

Upwork Job

Reviewer: @abdulrahuman5196 owed $250 via NewDot
Reviewer: @dukenv0307 owed $250 via NewDot

BugZero Checklist (@maddylewis)

I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1922282923967120988/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: Not a regression. Seems to be very old code and we might not have noticied this issue.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Go to Reports page
Go to Tasks page
Click on completed task
Note that RHN modal is still displayed
On RHN, click on task title > Mark as incomplete button
Verify that the RHN modal is still displayed

Do we agree 👍 or 👎

@maddylewis

@maddylewis Checklist is complete

@maddylewis

@maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

@maddylewis

@maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

@abdulrahuman5196

Payment Overview + Final To-Dos:

Reviewer: @abdulrahuman5196 owed $250 via NewDot
Reviewer: @dukenv0307 owed $250 via NewDot
regression test GH

@abdulrahuman5196

$250 approved for @abdulrahuman5196

@dukenv0307

Approved $250 to @dukenv0307

Navigation Menu

Repository navigation

[Due for payment 2025-06-27] [$250] The RHN modal is dismissed after clicking incomplete button in task #61907

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

31 remaining items

Payment Summary

BugZero Checklist (@maddylewis)

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Payment Overview + Final To-Dos:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	action: callFunctionIfActionIsAllowed(() => {
	Navigation.dismissModal();
	reopenTask(report);
	}),

	items.push({
	key: CONST.REPORT_DETAILS_MENU_ITEM.MARK_AS_INCOMPLETE,
	icon: Expensicons.Checkmark,
	translationKey: 'task.markAsIncomplete',
	isAnonymousAction: false,
	action: callFunctionIfActionIsAllowed(() => {
	Navigation.dismissModal();
	reopenTask(report);
	}),
	});

[Due for payment 2025-06-27] [$250] The RHN modal is dismissed after clicking incomplete button in task #61907

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 13, 2025

m-natarajan commented on May 13, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 13, 2025

melvin-bot commented on May 13, 2025

AQIB-NAWAB commented on May 17, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 19, 2025

31 remaining items

melvin-bot commented on Jun 27, 2025

Payment Summary

BugZero Checklist (@maddylewis)

abdulrahuman5196 commented on Jun 30, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

abdulrahuman5196 commented on Jun 30, 2025

melvin-bot commented on Jun 30, 2025

melvin-bot commented on Jun 30, 2025

maddylewis commented on Jun 30, 2025

Payment Overview + Final To-Dos:

JmillsExpensify commented on Jul 14, 2025

quinthar commented on Sep 15, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions