[$250] Incorrect Button Size on "Invite Whisper" Modal

@dubielzyk-expensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.44-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Navigate to any workspace
@mention a user who's not on that workspace
See the message with small buttons

Expected Result:

Buttons should be size "medium"

Actual Result:

Buttons are currently size "small"

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021923391355281009698
Upwork Job ID: 1923391355281009698
Last Price Increase: 2025-05-16

Issue Owner

Current Issue Owner: @twisterdotcom

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dukenv0307

Proposal by @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

The buttons on the "invite whisper" are size small

What is the root cause of that problem?

We forgot to add isMediumSized as true in actionableMentionWhisperOptions action like we did with others

App/src/pages/home/report/PureReportActionItem.tsx

Lines 751 to 764 in 12e6cb3

    
               return [ 
        
                   { 
        
                       text: 'actionableMentionWhisperOptions.invite', 
        
                       key: `${action.reportActionID}-actionableMentionWhisper-${CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE}`, 
        
                       onPress: () => resolveActionableMentionWhisper(reportID, action, CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE), 
        
                       isPrimary: true, 
        
                   }, 
        
                   { 
        
                       text: 'actionableMentionWhisperOptions.nothing', 
        
                       key: `${action.reportActionID}-actionableMentionWhisper-${CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.NOTHING}`, 
        
                       onPress: () => resolveActionableMentionWhisper(reportID, action, CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.NOTHING), 
        
                   }, 
        
               ]; 
        
           }, [

What changes do you think we should make in order to solve the problem?

We should add isMediumSized as true

        {
                text: 'actionableMentionWhisperOptions.invite',
                ...
                isMediumSized: true,
                isPrimary: true,
        },
        {
                text: 'actionableMentionWhisperOptions.nothing',
                ...
                isMediumSized: true,
        },

App/src/pages/home/report/PureReportActionItem.tsx

Lines 751 to 764 in 12e6cb3

    
               return [ 
        
                   { 
        
                       text: 'actionableMentionWhisperOptions.invite', 
        
                       key: `${action.reportActionID}-actionableMentionWhisper-${CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE}`, 
        
                       onPress: () => resolveActionableMentionWhisper(reportID, action, CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE), 
        
                       isPrimary: true, 
        
                   }, 
        
                   { 
        
                       text: 'actionableMentionWhisperOptions.nothing', 
        
                       key: `${action.reportActionID}-actionableMentionWhisper-${CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.NOTHING}`, 
        
                       onPress: () => resolveActionableMentionWhisper(reportID, action, CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.NOTHING), 
        
                   }, 
        
               ]; 
        
           }, [

Note: We should also check other actionable buttons to see if they are the correct size.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None UI bug

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021923391355281009698

@akinwale

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

Inside InviteToWhisperModal.js, or where the modal is rendered:

<ConfirmModal
...
confirmText "Invite"
onConfirm={handleInvite}
confirmButtonStyles={[styles.buttonLarge, styles.p5, styles.mt5]}
confirmTextStyle={[styles.textStrong, styles.textNormal]}
...
/>
If not using ConfirmModal, and the button is direct:
<Button
text="Invite"
onPress={handleInvite}
style={[styles.buttonLarge, styles.mt5]}
textStyles={[styles.textStrong, styles.textNormal]}
success
/>

This aligns the button size with the design standards used across the app.

@samoousama

📣 @samoousama! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@akinwale

How is this going @akinwale? Any good proposals yet?

@dukenv0307

@dukenv0307's proposal works here.

@dukenv0307 could you post a comment on this issue so that you can be assigned?

🎀👀🎀 C+ reviewed.

@pecanoro

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@dukenv0307

Assigning @dukenv0307 to the issue

@akinwale

This issue was fixed in: #62085. So I think we don't need to open the PR cc @akinwale

@twisterdotcom

This issue was fixed in: #62085. So I think we don't need to open the PR cc @akinwale

In that case, I believe this can be closed with 50% compensation due.

cc @twisterdotcom

@akinwale

Payment Summary:

@akinwale paid $125 via New Expensify (Reviewer)
@dukenv0307 paid $125 via New Expensify (Contributor)

@dukenv0307

$125 approved for @dukenv0307

@akinwale

$125 approved for @akinwale

Navigation Menu

Repository navigation

[$250] Incorrect Button Size on "Invite Whisper" Modal #61905

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

1 remaining item

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	return [
	{
	text: 'actionableMentionWhisperOptions.invite',
	key: `${action.reportActionID}-actionableMentionWhisper-${CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE}`,
	onPress: () => resolveActionableMentionWhisper(reportID, action, CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE),
	isPrimary: true,
	},
	{
	text: 'actionableMentionWhisperOptions.nothing',
	key: `${action.reportActionID}-actionableMentionWhisper-${CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.NOTHING}`,
	onPress: () => resolveActionableMentionWhisper(reportID, action, CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.NOTHING),
	},
	];
	}, [

[$250] Incorrect Button Size on "Invite Whisper" Modal #61905

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 13, 2025

m-natarajan commented on May 13, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 16, 2025

melvin-bot commented on May 16, 2025

samoousama commented on May 16, 2025

melvin-bot commented on May 16, 2025

1 remaining item

twisterdotcom commented on May 20, 2025

akinwale commented on May 21, 2025

melvin-bot commented on May 21, 2025

pecanoro commented on May 21, 2025

dukenv0307 commented on May 22, 2025

akinwale commented on May 22, 2025

twisterdotcom commented on May 23, 2025

JmillsExpensify commented on Jun 9, 2025

JmillsExpensify commented on Jun 9, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions