[Due for payment 2025-08-20] [$250] Sign in - User is not redirected to IOU report when logging in after deeplink

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6074628
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 /Chrome, Samsung Galaxy s10/ Chrome, Samsung Galaxy s10/ Android 12
App Component: Other

Action Performed:

Preconditions: Account with existing IOU report, IOU report URL copied and navigate to some other report

1. Log out of the app if logged in
2. Navigate to IOU report URL
3. Log in with the account from preconditions

Expected Result:

User should be redirected to correct IOU report

Actual Result:

User is not redirected. The app displays other LHN chats.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6825693_1746711884821.bandicam_2025-05-08_16-43-11-771.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021921868364892789132
• Upwork Job ID: 1921868364892789132
• Last Price Increase: 2025-05-26

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-08 21:38:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sign in - User is not redirected to IOU report when logging in after deeplink

What is the root cause of that problem?

we navigate to the deep linked report only if it exists in onyx allRerports

App/src/libs/actions/Report.ts

Lines 3314 to 3327 in 8c3841b

	const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
	// If the report does not exist, navigate to the last accessed report or Concierge chat
	if (reportID && !report) {
	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
	Navigation.navigate(lastAccessedReportRoute);
	return;
	}
	navigateToConciergeChat(false, () => true);
	return;
	}
	Navigation.navigate(route as Route);

otherwise we navigate to the last accessed report. But, in this case, when we sign in deep linking into iou reports (or any child reports) the report will only be available in onyx after the user opens it so we will be navigated to the last accessed report

What changes do you think we should make in order to solve the problem?

As the deeplinkeed report might not exist in onyx and can be loaded after opening the report, we need to remove this code

App/src/libs/actions/Report.ts

Lines 3313 to 3325 in 8c3841b

	// Check if the report exists in the collection
	const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
	// If the report does not exist, navigate to the last accessed report or Concierge chat
	if (reportID && !report) {
	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
	Navigation.navigate(lastAccessedReportRoute);
	return;
	}
	navigateToConciergeChat(false, () => true);
	return;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[dmkt9]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-17 10:46:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is not redirected. The app displays other LHN chats.

What is the root cause of that problem?

• The report route is a protected route, causing openReport to fail data fetching here:
  

  App/src/libs/actions/Report.ts

  Line 3257 in a936418

  openReport(reportID, '', [], undefined, '0', true);

• This makes the report variable undefined at this location:
  

  App/src/libs/actions/Report.ts

  Line 3316 in a936418

  const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];

• Navigation then falls back to last visited report or concierge chat:
  

  App/src/libs/actions/Report.ts

  Lines 3318 to 3327 in a936418

  	if (reportID && !report) {
  	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
  	if (lastAccessedReportID) {
  	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
  	Navigation.navigate(lastAccessedReportRoute);
  	return;
  	}
  	navigateToConciergeChat(false, () => true);
  	return;
  	}

What changes do you think we should make in order to solve the problem?

• Upon login, check if report with this reportID exists and is accessible:
  

  App/src/libs/actions/Report.ts

  Line 3284 in 32d67b3

  const connection = Onyx.connect({

let openReportPromise = Promise.resolve();
let shouldForceNavigatingToRoute = {value: false};
if (reportID && !isAuthenticated) {
    openReport(reportID, '', [], undefined, '0', true);

    let openReportResolve: ()=>void;
    openReportPromise = new Promise((resolve)=>{
        openReportResolve = resolve;
    });
    const connection = Onyx.connect({
        key: ONYXKEYS.COLLECTION.REPORT,
        waitForCollectionCallback: true,
        callback: (value) => {
            const report = value?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
            if(report?.errorFields?.notFound || report?.reportID){
                Onyx.disconnect(connection);
                openReportResolve();
                shouldForceNavigatingToRoute.value = !!report?.reportID;
            }
        },
    });
}

• After opening the report, call handleDeeplinkNavigation:
  

  App/src/libs/actions/Report.ts

  Lines 3347 to 3351 in 32d67b3

  	isOnboardingFlowCompleted({
  	onNotCompleted: () => startOnboardingFlow(undefined, val),
  	onCompleted: handleDeeplinkNavigation,
  	onCanceled: handleDeeplinkNavigation,
  	});

onCompleted: () => openReportPromise.then(() => handleDeeplinkNavigation()),
onCanceled: () => openReportPromise.then(() => handleDeeplinkNavigation()),

• If we can access the report, navigate to the route:
  

  App/src/libs/actions/Report.ts

  Line 3328 in 32d67b3

  if (reportID && !report) {

if (!shouldForceNavigatingToRoute.value && reportID && !report?.reportID) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021921868364892789132

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)