[Due for payment 2025-06-11] Specific error message is not shown in UI for issuing Expensify card, instead generic error is shown

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @blimpich
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Setup a validated account with a bank account
2. Enable expensify card
3. Try to issue a physical expensify card, but purposely put in the wrong magic code on the final step

Expected Result:

user should see error that says Looks like the magic code you entered was incorrect. Please try again.

Actual Result:

user sees this error: Oops... something went wrong and your request could not be completed. Please try again later.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

specific error message is not shown in errors at bottom for issuing Expensify card, instead generic error message is shown.

What is the root cause of that problem?

When calling issueExpensifyCard, we set the errors value to common.genericErrorMessage in the failureData. This ensures that if the api/CreateExpensifyCard API fails and does not send errors in the OnyxData from the backend, we display the generic error message instead.

App/src/libs/actions/Card.ts

Line 763 in 1b8fbc7

errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),

What changes do you think we should make in order to solve the problem?

This issue can be resolved on the backend. Once it's fixed and we've confirmed through testing that the frontend fallback is no longer needed, we can remove errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage') from issueExpensifyCard's failureData.

On the backend, we should send the error using the errors key in the expected format, rather than just sending a message key.

like this:

"onyxData": [
        {
            "key": "cards_19194597_Expensify Card",
            "onyxMethod": "merge",
            "value": {
                "22523979": {
                    "errors": "Looks like the magic code you entered was incorrect. Please try again."
                }
            }
        },
        {
            "key": "cards_19194597_Expensify Card",
            "onyxMethod": "merge",
            "value": {
                "22523979": {
                    "errors": "Looks like the magic code you entered was incorrect. Please try again."
                }
            }
        }
    ],
"onyxUpdates": {
    "5018525698": [
        {
            "key": "cards_19194597_Expensify Card",
            "onyxMethod": "merge",
            "value": {
                "22523979": {
                    "errors": "Looks like the magic code you entered was incorrect. Please try again."
                }
            }
        }
    ]
},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can mock the issueExpensifyCard function and write a test to verify the API behavior.

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

@mountiny @VickyStash @koko57 @joekaufmanexpensify putting this on your radar as Ecard related. I'm surprised we haven't run into this before. It's seemingly internal though.

[trjExpensify]

@danielrvidal what do you think about moving this one in to #convert? I feel like it's an error in a pretty important flow for us (issuing cards), so telling them just to "try again later" is misleading.

[danielrvidal]

Sounds good to me, added to the weekly update.