[WAITING ON BRUNO] [$250] Invoice-Inconsistency in exporting unpaid invoice depending on where export button is accessed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+sd89ns@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Log in to Expensifail account
• Workspace is connected to Sage Intacct
• Workspace has enabled invoicing feature

1. Go to staging.new.expensify.com
2. Open FAB > Send invoice
3. Send an invoice to any user
4. In invoice room, click on the expense preview
5. Click on the report header
6. Click Export
7. Note that the page shows a blocking view because the invoice is not paid so it cannot be exported
8. Close the RHP
9. Click More
10. Click Export to Sage Intacct
11. Click Mark as manually exported

Expected Result:

User should not be able to export the unpaid invoice to Sage Intacct or mark it as manually exported when the buttons are accessed from More menu because of the blocking page in Step 7

Actual Result:

User can export the unpaid invoice to Sage Intacct or mark it as manually exported when the buttons are accessed from More menu despite the blocking page in Step 7
There is inconsistency in exporting unpaid invoice depending on where the export button is accessed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6824367_1746628554493.20250507_223003.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021920149660873832851
• Upwork Job ID: 1920149660873832851
• Last Price Increase: 2025-06-11
• Automatic offers:
• brunovjk | Reviewer | 107711144
• FitseTLT | Contributor | 107711145

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-07 15:12:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice-Inconsistency in exporting unpaid invoice depending on where export button is accessed

What is the root cause of that problem?

In the More buttons case we are showing export options for invoice reports

App/src/libs/ReportSecondaryActionUtils.ts

Lines 196 to 198 in 09675e5

	if (isInvoiceReport && isReportSender) {
	return true;
	}

then on pressing it we are not navigating to export page but instead directly export here

App/src/components/MoneyReportHeader.tsx

Line 598 in 09675e5

exportToIntegration(moneyRequestReport?.reportID, connectedIntegration);

but in the case of report details page we are navigating to export details page which will inform them that the report cannot be exported

App/src/pages/ReportDetailsPage.tsx

Line 599 in 09675e5

Navigation.navigate(ROUTES.REPORT_WITH_ID_DETAILS_EXPORT.getRoute(report?.reportID, connectedIntegration, backTo));

App/src/pages/home/report/ReportDetailsExportPage.tsx

Lines 84 to 103 in 09675e5

	if (!canBeExported) {
	return (
	<ScreenWrapper testID={ReportDetailsExportPage.displayName}>
	<HeaderWithBackButton
	title={translate('common.export')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(reportID, backTo))}
	/>
	<ConfirmationPage
	illustration={Illustrations.LaptopWithSecondScreenAndHourglass}
	heading={translate('workspace.export.notReadyHeading')}
	description={translate('workspace.export.notReadyDescription')}
	shouldShowButton
	buttonText={translate('common.buttonConfirm')}
	onButtonPress={() => Navigation.goBack()}
	illustrationStyle={{width: 233, height: 162}}
	containerStyle={styles.flex1}
	/>
	</ScreenWrapper>
	);
	}

but canBeExport is true only for expense report with the proper state

App/src/libs/ReportUtils.ts

Lines 10320 to 10325 in 09675e5

	function canBeExported(report: OnyxEntry<Report>) {
	if (!report?.statusNum) {
	return false;
	}
	const isCorrectState = [CONST.REPORT.STATUS_NUM.APPROVED, CONST.REPORT.STATUS_NUM.CLOSED, CONST.REPORT.STATUS_NUM.REIMBURSED].some((status) => status === report.statusNum);
	return isExpenseReport(report) && isCorrectState;

so not only will it prevent the export because of the invoice report's status but it doesn't allow non-expense reports at all.

What changes do you think we should make in order to solve the problem?

We need to hide export for invoice reports so update

App/src/libs/ReportSecondaryActionUtils.ts

Lines 267 to 272 in 838f01d

	const isInvoiceReport = isInvoiceReportUtils(report);
	const isReportSender = isCurrentUserSubmitter(report.reportID);
	if (isInvoiceReport && isReportSender) {
	return true;
	}

if (isInvoiceReport) {
        return false;
    }

App/src/libs/ReportPrimaryActionUtils.ts

Lines 181 to 183 in 838f01d

	if (!connectedIntegration) {
	return false;
	}

 const isInvoiceReport = isInvoiceReportUtils(report);

    if (!connectedIntegration || isInvoiceReport) {
        return false;
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021920149660873832851

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[brunovjk]

It's on my list, I'll review it ASAP

[bradyrose]

Withdrawing this proposal to comply with Expensify’s one-proposal-at-a-time policy.
Hope to circle back if it’s still open later. Thanks!

[melvin-bot]

@brunovjk Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!