[Due for payment 2025-05-30] [$250] Concierge Categorization Message Uses Incorrect Styles

@shawnborton

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

As admin view the uncategorized submitted expense
Observe the Concierge categorization message

Expected Result:

Use normal message body text.
Use medium-sized buttons to match other message interactions.
Ensure styling is consistent with our current design system and previously approved specs.

Actual Result:

Message text is styled with bold/headline formatting rather than standard body text.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

Expected result with regular message style and medium-size buttons

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021919526308249144611
Upwork Job ID: 1919526308249144611
Last Price Increase: 2025-05-05
Automatic offers:

dominictb | Contributor | 107189064

Issue Owner

Current Issue Owner: @mallenexpensify

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@jasperhuangg

cc @jasperhuangg @marcochavezf @thienlnam

@mallenexpensify

@mallenexpensify I can reproduce the issue following the same steps in OP:

I can take over as C+ as per this Slack thread.

🚨 Edited by proposal-police: This proposal was edited at 2025-05-05 19:34:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Concierge Categorization Message Uses Incorrect Styles

What is the root cause of that problem?

isMediumSized: true is not passed here.

App/src/pages/home/report/PureReportActionItem.tsx

Lines 663 to 668 in 700d44a

    
           text: `${i + 1} - ${option}`, 
        
           key: `${action.reportActionID}-conciergeCategoryOptions-${option}`, 
        
           onPress: () => { 
        
               addComment(originalReportID, option); 
        
           }, 
        
           isDisabled: isResolved,

We do pass this prop to other buttons.

App/src/pages/home/report/PureReportActionItem.tsx

Line 685 in 700d44a

isMediumSized: true,

App/src/pages/home/report/PureReportActionItem.tsx

Line 693 in 700d44a

isMediumSized: true,

...

What changes do you think we should make in order to solve the problem?

pass isMediumSized: true here to fix the button size.

App/src/pages/home/report/PureReportActionItem.tsx

Lines 663 to 668 in 700d44a

    
           text: `${i + 1} - ${option}`, 
        
           key: `${action.reportActionID}-conciergeCategoryOptions-${option}`, 
        
           onPress: () => { 
        
               addComment(originalReportID, option); 
        
           }, 
        
           isDisabled: isResolved,

additionally pass as additional button style to fix font style and weight.

textStyles={[styles.fontWeightNormal, FontUtils.fontFamily.platform.EXP_NEW_KANSAS_MEDIUM]}

pass here if we just want categorize buttons to have normal font weight

App/src/pages/home/report/PureReportActionItem.tsx

Lines 663 to 668 in 700d44a

    
           text: `${i + 1} - ${option}`, 
        
           key: `${action.reportActionID}-conciergeCategoryOptions-${option}`, 
        
           onPress: () => { 
        
               addComment(originalReportID, option); 
        
           }, 
        
           isDisabled: isResolved,

or pass here if we want every concierge action button to render with normal font weight.

App/src/components/ReportActionItem/ActionableItemButtons.tsx

Line 31 in d231433

<Button

Note

FontUtils.fontFamily.platform.EXP_NEW_KANSAS_MEDIUM is just an example, fint style should be confirmed with design team.

and we need to verify the font weight for primary buttons ie. success style buttons as well.
and conditionally pass above style in case we want to render primary button with bold text

Also pass the font style as additional styles EXP_NEW_KANSAS_MEDIUM or whatever font style design team suggests.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Reviewing label has been removed, please complete the "BugZero Checklist".

@bernhardoj

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix concierge categorize message styling #62085

If no regressions arise, payment will be issued on 2025-05-30. 🎊

For reference, here are some details about the assignees on this issue:

@bernhardoj requires payment through NewDot Manual Requests
@dominictb requires payment automatic offer (Contributor)

@dominictb

@dominictb @mallenexpensify @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mallenexpensify

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: Design update

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: NA, design update
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

A workspace with "Members must categorize all expenses" enabled

Test:

Submit an expense to that workspace without setting a category
Verify the auto categorization message from Concierge has normal font weight and medium sized buttons like this mockup:

Do we agree 👍 or 👎

@dominictb

Contributor: @dominictb paid $250 via Upwork
Contributor+: @bernhardoj due $250 via NewDot

Test case created, thx y'all

https://github.com/Expensify/Expensify/issues/507542

Requested in ND.

@bernhardoj

$250 approved for @bernhardoj

Navigation Menu

Repository navigation

[Due for payment 2025-05-30] [$250] Concierge Categorization Message Uses Incorrect Styles #61384

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

37 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	text: `${i + 1} - ${option}`,
	key: `${action.reportActionID}-conciergeCategoryOptions-${option}`,
	onPress: () => {
	addComment(originalReportID, option);
	},
	isDisabled: isResolved,

[Due for payment 2025-05-30] [$250] Concierge Categorization Message Uses Incorrect Styles #61384

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 5, 2025

MelvinBot commented on May 5, 2025

shawnborton commented on May 5, 2025

dominictb commented on May 5, 2025

ChavdaSachin commented on May 5, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

37 remaining items

melvin-bot commented on May 23, 2025

melvin-bot commented on May 23, 2025

melvin-bot commented on May 23, 2025

melvin-bot commented on Jun 2, 2025

dominictb commented on Jun 2, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

mallenexpensify commented on Jun 3, 2025

bernhardoj commented on Jun 3, 2025

JmillsExpensify commented on Jun 9, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions