[Due for payment 2025-05-20] [$250] The header for track expense is different from regular expenses

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.38-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation (hyperlinked to channel name): #Migrate

Action Performed:

1. Track a manual expense
2. Navigate to the expense details
3. Observe the header

Expected Result:

The header format for all expenses, including "Track Expense" and regular expenses, should be consistent and follow the pattern:
$x.xx for [merchant/description]

Actual Result:

The "Track Expense" header uses a different format than regular expenses:
Tracking $x.xx for [Description]

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917699897823842474
• Upwork Job ID: 1917699897823842474
• Last Price Increase: 2025-04-30
• Automatic offers:
• FitseTLT | Contributor | 107139891

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-30 14:43:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The header for track expense is different from regular expenses

What is the root cause of that problem?

WE are using a different copy threadTrackReportName which says tracking ... for track expense

App/src/libs/ReportUtils.ts

Lines 4105 to 4107 in 03dfc95

	if (isTrackExpenseAction(reportAction)) {
	return translateLocal('iou.threadTrackReportName', {formattedAmount, comment});
	}

App/src/languages/en.ts

Line 1064 in 03dfc95

threadTrackReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `Tracking ${formattedAmount} ${comment ? `for ${comment}` : ''}`,

What changes do you think we should make in order to solve the problem?

We can update the copy to remove tracking text

App/src/languages/en.ts

Line 1064 in 03dfc95

threadTrackReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `Tracking ${formattedAmount} ${comment ? `for ${comment}` : ''}`,

        threadTrackReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `for ${comment}` : ''}`,

and also the Spanish translation

Or remove the code

App/src/libs/ReportUtils.ts

Lines 4105 to 4107 in 03dfc95

	if (isTrackExpenseAction(reportAction)) {
	return translateLocal('iou.threadTrackReportName', {formattedAmount, comment});
	}

so that we can fallback to the common threadExpenseReportName copy to be consistent but this will have an expense appended when there is no comment but if we want to remove that or use another text more relevant with tracking we can still re-use the copy by adding a param in threadExpenseReportName copy and replace expense text accordingly for track.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

if needed we can assert the new changes on a test performed with getReportName for track expense report

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917699897823842474

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jliexpensify]

Just going to cc @Expensify/design on this (as a courtesy, if they want to review or leave feedback on what exact changes are required)

[shawnborton]

Thanks! I think the idea is that all expenses should use the same template for the header. Which is generally $X.XX for X

[jjcoffee]

@FitseTLT's proposal LGTM! We can tweak on the PR, but I think removing the separate condition for isTrackExpenseAction altogether makes sense.

🎀👀🎀 C+ reviewed