[Due for payment 2025-05-14] [$250] Expense Reports - Total amount in report header does not update after editing expense amount

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.33-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #60694
Email or phone of affected tester (no customers): applausetester+cnmnmc6@applause.expensifail.com
**Issue reported by:**n Applause - Internal Team

Action Performed:

Precondition:

• Log in with Expensifail account

1. Go to staging.new.expensify.com
2. Go to 1:1 DM
3. Submit two expenses in 1:1 DM
4. Go to Reports
5. Go to Expense Reports
6. Click on the expense report from Step 3
7. Click on any transaction
8. Click Amount
9. Edit amount and save it
10. Close the RHP

Expected Result:

The total amount in the report header "x owes amount" will update to the latest amount

Actual Result:

The total amount in report header does not update after editing expense amount

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6816274_1745922134381.20250429_181844.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917276610174945314
• Upwork Job ID: 1917276610174945314
• Last Price Increase: 2025-04-29

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense Reports - Total amount in report header does not update after editing expense amount

What is the root cause of that problem?

When the if condition below holds to be true, we use cached report name that is stored in attributes[report.reportID].reportName as report title.

App/src/libs/ReportUtils.ts

Lines 4607 to 4613 in d391099

	const canUseDerivedValue = report && policy === undefined && parentReportActionParam === undefined && personalDetails === undefined && invoiceReceiverPolicy === undefined;
	const attributes = reportAttributesParam ?? reportAttributes;
	const derivedNameExists = report && !!attributes?.[report.reportID]?.reportName;
	if (canUseDerivedValue && derivedNameExists) {
	return attributes[report.reportID].reportName;
	}
	return getReportNameInternal({report, policy, parentReportActionParam, personalDetails, invoiceReceiverPolicy});

And the cached reportName gets updated when we update the amount (ONYXKEYS.DERIVED.REPORT_ATTRIBUTES value is change is detected) below

App/src/libs/ReportUtils.ts

Lines 1043 to 1049 in d391099

	Onyx.connect({
	key: ONYXKEYS.DERIVED.REPORT_ATTRIBUTES,
	callback: (value) => {
	if (!value) {
	return;
	}
	reportAttributes = value.reports;

But the title on report header won't be updated since we are not calling getReportName after the cached reportName is updated

What changes do you think we should make in order to solve the problem?

We should pass personalDetails as forth argument so that we can recalculate report title here every time total amount changes rather than using cached reportName

App/src/components/AvatarWithDisplayName.tsx

Line 76 in d391099

const title = getReportName(report, undefined, undefined, undefined, invoiceReceiverPolicy);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A - U/I issue

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense report header title doesn't change when the report total is updated.

What is the root cause of that problem?

We get the report name from reportAttributes since only report param is available (not undefined).

App/src/components/AvatarWithDisplayName.tsx

Line 76 in d9c8c32

const title = getReportName(report, undefined, undefined, undefined, invoiceReceiverPolicy);

App/src/libs/ReportUtils.ts

Lines 4606 to 4613 in d9c8c32

	// Check if we can use report name in derived values - only when we have report but no other params
	const canUseDerivedValue = report && policy === undefined && parentReportActionParam === undefined && personalDetails === undefined && invoiceReceiverPolicy === undefined;
	const attributes = reportAttributesParam ?? reportAttributes;
	const derivedNameExists = report && !!attributes?.[report.reportID]?.reportName;
	if (canUseDerivedValue && derivedNameExists) {
	return attributes[report.reportID].reportName;
	}
	return getReportNameInternal({report, policy, parentReportActionParam, personalDetails, invoiceReceiverPolicy});

reportAttributes will be updated when the deps change.

App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts

Lines 14 to 79 in d9c8c32

	dependencies: [
	ONYXKEYS.COLLECTION.REPORT,
	ONYXKEYS.NVP_PREFERRED_LOCALE,
	ONYXKEYS.PERSONAL_DETAILS_LIST,
	ONYXKEYS.COLLECTION.TRANSACTION,
	ONYXKEYS.COLLECTION.REPORT_ACTIONS,
	ONYXKEYS.COLLECTION.POLICY,
	ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS,
	ONYXKEYS.COLLECTION.REPORT_METADATA,
	],
	compute: (dependencies, {currentValue, sourceValues}) => {
	const areAllDependenciesSet = [...dependencies].every((dependency) => dependency !== undefined);
	if (!areAllDependenciesSet) {
	return {
	reports: {},
	locale: null,
	};
	}
	const [reports, preferredLocale] = dependencies;
	// if the preferred locale has changed, reset the isFullyComputed flag
	if (preferredLocale !== currentValue?.locale) {
	isFullyComputed = false;
	}
	const reportUpdates = sourceValues?.[ONYXKEYS.COLLECTION.REPORT];
	const reportMetadataUpdates = sourceValues?.[ONYXKEYS.COLLECTION.REPORT_METADATA];
	// if we already computed the report attributes and there is no new reports data, return the current value
	if ((isFullyComputed && reportUpdates === undefined && reportMetadataUpdates === undefined) || !reports) {
	return currentValue ?? {reports: {}, locale: null};
	}
	let dataToIterate: Record<string, Report | ReportMetadata | undefined> = reports;
	if (isFullyComputed) {
	if (reportUpdates) {
	dataToIterate = reportUpdates;
	} else if (reportMetadataUpdates) {
	dataToIterate = reportMetadataUpdates;
	}
	}
	const reportAttributes = Object.keys(dataToIterate).reduce<ReportAttributesDerivedValue['reports']>((acc, key) => {
	// source value sends partial data, so we need an entire report object to do computations
	const report = reports[`${ONYXKEYS.COLLECTION.REPORT}${key.replace(ONYXKEYS.COLLECTION.REPORT, '').replace(ONYXKEYS.COLLECTION.REPORT_METADATA, '')}`];
	if (!report || !isValidReport(report)) {
	return acc;
	}
	acc[report.reportID] = {
	reportName: generateReportName(report),
	};
	return acc;
	}, currentValue?.reports ?? {});
	// mark the report attributes as fully computed after first iteration to avoid unnecessary recomputations on all objects
	if (reportUpdates === undefined && Object.keys(reports ?? {}).length > 0 && !isFullyComputed) {
	isFullyComputed = true;
	}
	return {
	reports: reportAttributes,
	locale: preferredLocale ?? null,
	};
	},

However, even though reportAttributes is updated, it won't trigger a re-render since we don't subscribe to it.

What changes do you think we should make in order to solve the problem?

Subscribe to reportAttributes and pass it to getReportName.

const [reportAttributes] = useOnyx(ONYXKEYS.DERIVED.REPORT_ATTRIBUTES, {selector: (attributes) => attributes?.reports, canBeMissing: false});
const title = getReportName(report, undefined, undefined, undefined, invoiceReceiverPolicy, reportAttributes);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917276610174945314

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@bernhardoj's proposal looks good to me

🎀👀🎀 C+ reviewed