Coming from this proposal.
Background:
When users open an expense report from the "Reports" tab, the application displays the detailed report information. Currently, the useSearchHighlightAndScroll hook is doing more than what its name suggests - beyond just handling UI highlighting and scrolling functions, it's also making API calls to the /Search endpoint. Hooks should ideally have single responsibilities that match their names, but this hook is currently performing data fetching operations that lie outside its intended purpose.
Problem:
When a user opens an expense report, multiple redundant calls to the /Search endpoint are triggered (by useSearchHighlightAndScroll hook), wasting network resources and impacting application performance.
Solution:
We will separate the concerns by:
- Refining useSearchHighlightAndScroll to handle only UI tasks (highlighting and scrolling)
- Creating a new useSearchPusherUpdates hook in Search/index.tsx to handle Pusher update events and make /Search API calls only when necessary
This separation will maintain functionality while reducing network overhead and improving performance.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021917145585218173680
- Upwork Job ID: 1917145585218173680
- Last Price Increase: 2025-06-12
Issue Owner
Current Issue Owner: @JmillsExpensify / @Christinadobrzyn
Coming from this proposal.
Background:
When users open an expense report from the "Reports" tab, the application displays the detailed report information. Currently, the useSearchHighlightAndScroll hook is doing more than what its name suggests - beyond just handling UI highlighting and scrolling functions, it's also making API calls to the /Search endpoint. Hooks should ideally have single responsibilities that match their names, but this hook is currently performing data fetching operations that lie outside its intended purpose.
Problem:
When a user opens an expense report, multiple redundant calls to the /Search endpoint are triggered (by useSearchHighlightAndScroll hook), wasting network resources and impacting application performance.
Solution:
We will separate the concerns by:
This separation will maintain functionality while reducing network overhead and improving performance.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @JmillsExpensify / @Christinadobrzyn