[$250] Fix the tests for approval flow `getApprovalChain`

[tgolen]

Discussed in Slack here (open-source channel)

Problem

The unit test for describe('has transaction match with approver rule' is only passing on main due to async code not running. When a return is added to the final Onyx.merge( to ensure the assertions run asynchronously, the test then fails the assertion.

I believe the test to be broken

Solution

Make the test async and fix the assertion and code associated with it to have a correctly passing test.

cc @nkdengineer I believe you wrote the test, so I would ask you to fix this one.

Issue Owner

Current Issue Owner: @dominictb

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021930002373340928864
• Upwork Job ID: 1930002373340928864
• Last Price Increase: 2025-06-03

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

This issue has not been updated in over 15 days. @nkuoch eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hungvu193]

@nkuoch Could you assign BZ member here so they can handle the payment?

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.