mweb - Two offline indicators in "Join a workspace" page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.32-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54912
Email or phone of affected tester (no customers): kabejo1428@bauscn.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://temp-mail.org/en/
2. Keep deleting email until you get a private domain email from @agiuse.com, @lushosa.com or @bauscn.com (these private domains have existing users with workspaces)
3. Copy the temporary email
4. Go to staging.new.expensify.com
5. Enter the temporary email and log in
6. Enter name > Continue
7. Enter magic code
8. On "Join a workspace" page, go offline

Expected Result:

There will be one offline indicator in "Join a workspace" page

Actual Result:

There are two offline indicators in "Join a workspace" page

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6811705_1745503149777.Screen_Recording_20250424_215442_Chrome.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[mister-teddy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

2 offline idicators on the onboarding workspace page.

What is the root cause of that problem?

The <OfflineIndicator /> is conditionally rendered for small screen widths. But it already be rendered deeper in the hierarchy, under <ScreenWrapper />, leading to duplication.

What changes do you think we should make in order to solve the problem?

Remove this code:

App/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

Line 161 in 455570f

{isSmallScreenWidth && <OfflineIndicator />}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @mister-teddy! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mweb - Two offline indicators in "Join a workspace" page

What is the root cause of that problem?

We have a additional OfflineIndicator here

App/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

Line 161 in 53a4f33

{isSmallScreenWidth && <OfflineIndicator />}

That is not required since we already have ScreenWrapper

What changes do you think we should make in order to solve the problem?

Remove this code

App/src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

Line 161 in 53a4f33

{isSmallScreenWidth && <OfflineIndicator />}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mister-teddy]

Contributor details
Your Expensify account email: hongphat.js@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~011f970d574d50e8d9

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[samranahm]

This will be fix in #60643