[$250] Expense - Report field opens not here page after creating unreported expense on OD

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+240406kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Expensifail account (the account has no self DM).
3. Go to Settings > Domains to log in to OD.
4. Create an unreported expense on OD (Report is set to None).
5. Go back to ND.
6. Create a new workspace.
7. Go to workspace chat.
8. Submit a manual expense.
9. Go to expense report.
10. Click on the expense.
11. Click Report field.

Expected Result:

Report field will show a list of reports.

Actual Result:

Report field in workspace expense opens not here page after unreported expense is created on OD.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917010824944155693
• Upwork Job ID: 1917010824944155693
• Last Price Increase: 2025-04-29

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report field in workspace expense opens not here page after unreported expense is created on OD.

What is the root cause of that problem?

After creating unreported expense on OD, we have a report data like this in Onyx

The logic returns wrong policyID because in the edit flow transaction?.participants?.at(0)?.reportID is undefined and the report without reportID about can match this condition. Then the not found page appears because reportOptions is empty

App/src/pages/iou/request/step/IOURequestStepReport.tsx

Lines 51 to 55 in e1e89c9

	const policyID = Object.values(allReports ?? {}).find(
	(report) => report?.reportID === transaction?.reportID || report?.reportID === transaction?.participants?.at(0)?.reportID,
	)?.policyID;
	const expenseReports = getOutstandingReports(policyID, allReports ?? {});

What changes do you think we should make in order to solve the problem?

We should check if reportID is exist or not here

(report) => report?.reportID && report?.reportID === transaction?.reportID || report?.reportID === transaction?.participants?.at(0)?.reportID,

App/src/pages/iou/request/step/IOURequestStepReport.tsx

Lines 51 to 55 in e1e89c9

	const policyID = Object.values(allReports ?? {}).find(
	(report) => report?.reportID === transaction?.reportID || report?.reportID === transaction?.participants?.at(0)?.reportID,
	)?.policyID;
	const expenseReports = getOutstandingReports(policyID, allReports ?? {});

OPTIONAL: We can improve this condition to only compare report?.reportID with transaction?.reportID if we're in edit flow.

App/src/pages/iou/request/step/IOURequestStepReport.tsx

Lines 51 to 55 in e1e89c9

	const policyID = Object.values(allReports ?? {}).find(
	(report) => report?.reportID === transaction?.reportID || report?.reportID === transaction?.participants?.at(0)?.reportID,
	)?.policyID;
	const expenseReports = getOutstandingReports(policyID, allReports ?? {});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917010824944155693

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[mallenexpensify]

@sobitneupane 👀 on @nkdengineer 's proposal above plz